[csoceanu]

Summary

Default FULLSEND_APP_SET to fullsend-ai when the repository variable is unset. This preserves custom app-set identities while keeping repositories that update their workflows without rerunning fullsend repos install compatible with the review and fix paths.

Related Issue

• Follow-up to feat(review): add forge-backed review thread fetching #7907
• Unblocks feat(review): honor verified human-resolved findings agents#1635 for AISDLC-118

Changes

• Apply the fullsend-ai fallback consistently to workflow steps that consume the app-set identity.
• Pass the same effective app-set value to custom harness agents.
• Update workflow alignment tests and cover the generic harness-agent consumer.

Testing

• GOFLAGS=-mod=mod make lint
• go test -mod=mod ./internal/scaffold -count=1
• Focused workflow alignment tests
• Commit hooks, secret scanning, and git diff --check

Checklist

• PR title follows Conventional Commits (correct type, ! for breaking changes)
• Commits are signed off (DCO) — human and human-directed agent sessions only
• I wrote this contribution myself and can explain all changes in it

[github-actions]

E2E tests are running

Authorization passed for this commit. See the E2E Tests workflow for results.

[github-actions]

E2E tests did not run

E2E tests run automatically for org/repo members and collaborators on pull requests.

For other contributors, a maintainer with write access must add the ok-to-test label after the latest push.

See E2E testing guide for details.

[qodo-code-review]

PR Summary by Qodo

Default missing app-set identity in review and fix workflows

🐞 Bug fix 🧪 Tests 🕐 10-20 Minutes

AI Description

• Default an unset FULLSEND_APP_SET to fullsend-ai without changing configured app-set
 identities.
• Pass the effective identity to review, fix, and custom harness-agent steps so existing
 repositories remain compatible.
• Update workflow alignment tests to cover the fallback and harness-agent consumer.

Diagram

graph TD
  Vars["Repository variable"] --> Choice{"Configured?"} -->|Yes| Custom["Custom app set"] --> Env["Workflow environment"] --> Review["Review and fix"]
  Choice -->|No| Default["fullsend-ai default"] --> Env --> Harness["Harness agent"]

Loading

High-Level Assessment

Keep the fallback at the workflow steps that consume the identity. It preserves custom values and supports repositories that have not rerun installation; requiring a repository-variable migration or broadening environment scope would add work without improving this fix.

Files changed (2) +11 / -10

Bug fix (1) +6 / -5

reusable-dispatch.ymlDefault and propagate the app-set identity +6/-5

Default and propagate the app-set identity

• Uses 'fullsend-ai' when 'FULLSEND_APP_SET' is unset in routing, prior-review fetching, review-agent execution, fix eligibility, and review-body fetching. Also passes the same effective value to the generic harness agent; configured values remain unchanged.

.github/workflows/reusable-dispatch.yml

Tests (1) +5 / -5

workflow_call_alignment_test.goAssert the app-set fallback across workflow consumers +5/-5

Assert the app-set fallback across workflow consumers

• Updates workflow alignment assertions to expect the fallback expression. Extends the consumer-step check to include the generic harness agent.

internal/scaffold/workflow_call_alignment_test.go

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (1) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

1. Workflow guide review goes unrecorded 📘 Rule violation § Compliance

Description

The PR changes FULLSEND_APP_SET in reusable-dispatch.yml without stating that
docs/contributing/ci-workflows.md was consulted. The changed review-agent step runs in a workflow
callable from pull_request_target and passes secrets to the agent, but the PR description and
changed code contain no explicit consultation note.

Code

.github/workflows/reusable-dispatch.yml[1007]

+          FULLSEND_APP_SET: ${{ vars.FULLSEND_APP_SET || 'fullsend-ai' }}

Relevance

● Weak

Recent matching workflow-guide consultation finding was rejected in PR #7845 for the same
pull_request_target workflow context.

PR-#7845

ⓘ Recommendations generated based on similar findings in past PRs

Evidence

Rule 3201588 requires an explicit PR-description, checklist, or inline-comment reference to
consulting the CI workflow guide for qualifying workflow changes. The changed step passes secrets to
the review agent; fullsend.yaml calls this reusable workflow on pull_request_target, while the
supplied PR description has no guide-consultation statement.

Rule 3201588: Consult CI workflow guide when modifying GitHub Actions workflows or secrets
.github/workflows/reusable-dispatch.yml[1007-1029]
.github/workflows/fullsend.yaml[24-58]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The PR changes a secret-consuming workflow used by a pull-request-target caller without explicitly recording consultation of the CI workflow guide.

## Fix Focus Areas
- .github/workflows/reusable-dispatch.yml[1007-1007]

## Recommended Fix
Review docs/contributing/ci-workflows.md against the changed workflow, then add an explicit consultation statement to the PR description.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗

---

Context sources

✅ Compliance rules (platform): 89 rules

✅ Skills: 5 invoked

  writing-user-docs

  writing-adrs

  check-patch-coverage

  cutting-releases

  adr-corner

✅ Cross-repo context — repo relationships

  Explored: repo: fullsend-ai/agents (sha: f3dd8897) — View relationship

  Explored: repo: fullsend-ai/mlflow-assessments (sha: 2fdb0120) — View relationship

  Explored: repo: fullsend-ai/experiments (sha: 3f1614fa) — View relationship

  Explored: repo: fullsend-ai/.fullsend (sha: 7c163cad) — View relationship

  Explored: repo: fullsend-ai/pi-xai-vertex (sha: 8f50bdda) — View relationship

  Explored: repo: fullsend-ai/scribe (sha: 0f3eb528) — View relationship

  Explored: repo: fullsend-ai/pi-anthropic-vertex (sha: 960eff35) — View relationship

  Explored: repo: fullsend-ai/metrics (sha: aceacd33) — View relationship

Review mode: Auto: ⚖️ Balanced: Workflow behavior changes across multiple consumers require careful validation.

Tip of the day

💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!