Skip to content

ci(release): pin agents functional tests to the OpenShell 0.1 workflow - #7951

Merged
waynesun09 merged 1 commit into
mainfrom
release-agents-ft-pin
Oct 1, 2026
Merged

waynesun09 merged 1 commit into
mainfrom
release-agents-ft-pin

Conversation

@waynesun09

Copy link
Copy Markdown
Member

Summary

release.yml validates every release against agents' functional-tests reusable workflow, pinned at beed20e7 (2026-08-25). That version writes a schema v1 OpenShell gateway.toml before installing OpenShell. Since the move to OpenShell 0.1.2 (#7233), the gateway refuses that config and every validate-agents / functional-tests (*) job fails at Install OpenShell CLI:

gateway config preflight failed: path='/home/runner/.config/openshell/gateway.toml'
category=legacy_schema_v1 detected_version=1; the file was preserved unchanged; migrate it before restarting the gateway

This blocked v0.44.0-rc.1 (release run 36937963065). Nothing was published: release, tag-agents and the v0 move were all skipped.

This bumps the pin to agents main 291d39153, which writes the schema v2 config and starts the Podman API socket before installing OpenShell (agents#1513: 852ccc31a, c12d2671c, 82eacb852, 7470786c7). The reusable workflow's workflow_call interface is unchanged: the fullsend_ref input, the four optional secrets, and the agents_sha output.

release.yml only runs on tag pushes, so this gap wasn't visible in PR CI. agents' own PR functional-tests already run this workflow version against fullsend main and pass.

Test plan

  • pre-commit (actionlint, pinact) passes on the changed file
  • Compared workflow_call inputs, secrets, outputs and job names between beed20e7 and 291d39153: identical
  • After merge: tag v0.44.0-rc.2 and confirm validate-agents passes

release.yml validated the release against agents' functional-tests
workflow pinned at beed20e7 (2026-08-25). That version writes a
schema v1 OpenShell gateway.toml before installing OpenShell, so with
the 0.1.2 pin the gateway refuses to start (category=legacy_schema_v1)
and every functional-tests job fails at "Install OpenShell CLI".
v0.44.0-rc.1 was blocked this way before anything was published.

Pin to agents main 291d39153, which writes the schema v2 config and
starts the Podman API socket first (agents#1513). The reusable
workflow's inputs, secrets and outputs are unchanged.

Assisted-by: Claude
Signed-off-by: Wayne Sun <gsun@redhat.com>
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Fix release validation with an OpenShell-compatible agents workflow

🐞 Bug fix ⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Pin release validation to an agents workflow compatible with OpenShell 0.1.2.
• Restore the functional-test gate that blocked v0.44.0-rc.1 before publication.
Diagram

graph TD
  Tag["Release tag"] --> Resolve["Resolve agents"] --> Gate["Validate agents"] --> Tests["Pinned functional tests"] --> Recheck["Recheck tag"] --> Publish["Publish release"]
Loading
High-Level Assessment

Keep the reusable workflow pinned to the compatible commit. A floating agents branch would avoid manual pin updates but sacrifice reproducible release validation; changing the release gate itself is unnecessary because its call interface is unchanged.

Files changed (1) +1 / -1

Bug fix (1) +1 / -1
release.ymlPin the agents release gate to an OpenShell-compatible revision +1/-1

Pin the agents release gate to an OpenShell-compatible revision

• Replaces the agents functional-tests workflow SHA with a revision that uses the schema v2 gateway configuration and starts the Podman API socket. The workflow inputs and secrets passed by the release gate remain unchanged.

.github/workflows/release.yml

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (1) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Informational

1. Release pin lacks a workflow guide check 📘 Rule violation § Compliance
Description
The validate-agents workflow pin changes without a PR-description or inline note confirming that
docs/contributing/ci-workflows.md was consulted. The changed pin selects a new reusable workflow
for a release job that passes four secrets, so reviewers have no recorded confirmation that its
caller contract was checked against the guide.
Code

.github/workflows/release.yml[77]

+    uses: fullsend-ai/agents/.github/workflows/functional-tests.yml@291d391532ad223218e5594e9c3d9ecf41909d33 # main (schema v2 OpenShell gateway config + Podman socket, agents#1513)
Relevance

● Weak

The same CI-guide-evidence compliance finding was rejected for a recent reusable workflow change.

PR-#7845

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
Rule 3201588 requires explicit evidence that the CI workflow guide was consulted when modifying a
workflow. The changed line selects a new reusable workflow revision, while the PR description and
inline comment do not mention consulting the guide.

Rule 3201588: Consult CI workflow guide when modifying GitHub Actions workflows or secrets
.github/workflows/release.yml[77-86]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The release workflow pin changed, but the PR does not confirm consultation of the CI workflow guide.

## Fix Focus Areas
- .github/workflows/release.yml[77-77]

## Recommended Fix
Review `docs/contributing/ci-workflows.md` against the pinned workflow's caller contract and secret handling, then record that review in the PR description.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


Grey Divider

Context sources
✅ Compliance rules (platform): 72 rules
✅ Cross-repo context — repo relationships
  Explored: repo: fullsend-ai/agents (branch: main, sha: 291d3915) — View relationship
Review mode: ⚖️ Balanced: This is a localized CI workflow pin change, but it alters release validation behavior and external reusable-workflow execution, so a careful review is warranted.

Grey Divider

Tip of the day
💡 Did you know, you can keep summaries lean with Findings visible per group, which tucks the rest behind a View link

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@fullsend-ai-review

fullsend-ai-review Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 11:03 PM UTC · Completed 11:15 PM UTC

Commit: 5a8cae0 · View workflow run →

Runtime: pi · Model: openai/gpt-6.1-sol → gpt-6.1-sol · Effort: high · Cost: $1.82

@waynesun09
waynesun09 merged commit 352c9d9 into main Oct 1, 2026
21 checks passed
@waynesun09
waynesun09 deleted the release-agents-ft-pin branch October 1, 2026 23:05
@codecov

codecov Bot commented Oct 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review

Copy link
Copy Markdown

Review skipped — this PR is already merged.

The /fs-review command only reviews open PRs/MRs.

Posted by fullsend post-review check

This branch was previously deployed

1 inactive deployment
dev — 5a8cae03 Deployed Oct 1, 2026 by waynesun09 via behaviour #14934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant