Repository navigation
chore(deps): bump Ionide.Analyzers to 0.20.0 - #149
Merged
Merged
Conversation
Ionide.Analyzers 0.20.0 is built against FSharp.Analyzers.SDK 0.41, so the fsharp-analyzers tool moves to 0.41.0 in the same change. The 0.39 CLI refuses to load the new analyzers. Dependabot dropped the net10.0 graph from the lock file. Restore with --force-evaluate keeps both target frameworks. The analyzer job reads the package version from Directory.Packages.props instead of a hardcoded 0.19.0 path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FSharp.Interop.Dynamic/packages.lock.jsonwithdotnet restore --force-evaluate. Dependabot's lock file deleted thenet10.0graph, which failed restore with NU1004. Bothnetstandard2.0andnet10.0stay, with Ionide.Analyzers 0.20.0 on each.Directory.Packages.propsinstead of a hardcoded0.19.0cache path.Supersedes #145. #147 was the package half; Dependabot closed it after rebasing a lock file that still dropped
net10.0.Test plan
dotnet restore --locked-modedotnet build -c Release -warnaserror(0 warnings) withCI=truedotnet test— 106 passed, 0 failed, 0 skippeddotnet fsharp-analyzers0.41.0 against Ionide.Analyzers 0.20.0 exits 0 (hints and info only)