Add PHPStan to test environment with max level#195
Add PHPStan to test environment with max level#195bwaidelich wants to merge 1 commit intofriends-of-reactphp:0.7.xfrom
max level#195Conversation
|
Obviously this won't run with PHP 5.6 like this (wow, you really want to support these ancient versions?!) But even with PHP 8 PHPStan finds a lot of violations currently: https://github.com/friends-of-reactphp/mysql/actions/runs/8379359488/job/22946077184 |
|
I gave this one a quick try, but I won't be able to solve the type issues in my free time. There are too many.. Feel free to pick up this PR, but I'll close it for now |
|
@bwaidelich Thanks for looking into this 👍
Yeah, I agree with you that supporting these old PHP versions doesn't make much sense nowadays, especially when looking at the installations on Packagist for PHP < 7. We want to move away from these old versions, that's also why we're currently working on ReactPHP v3 and upgrading to a minimal support of PHP 7.1+. I want the same for ReactPHP MySQL, but this project is currently in a
Understandable and I appreciate the time you already put into this! Getting PHPStan to also run with all the legacy versions makes this whole topic way more complicated. This is also one reason why we didn't backport the PHPStan addition in Promise to I'm 100% sure that we'll pick up the whole PHPStan topic when working on a v3 in here, so I'll start looking into our plans for this component with the other ReactPHP maintainers first and revisit this afterwards 🚀 |
2 participants
No description provided.