Fix component type enums#219
Merged
Merged
Conversation
Add converters and enum parity tests for the component type enums before switching their pure wrappers away from protobuf constants. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Remove protobuf imports from the pure component type enum modules and rely on the parity tests to keep the integer literals aligned with the proto values. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax
requested review from
daniel-zullo-frequenz and
tiyash-basu-frequenz
and removed request for
a team
github-actions
Bot
added
part:tests
llucax
added
the
cmd:skip-release-notes
daniel-zullo-frequenz
approved these changes
Jun 18, 2026
Merged
via the queue into
frequenz-floss:v0.x.x
with commit Jun 18, 2026
c1c51cb
12 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use integer literals for component type enums and add proto converters and parity tests.
Part of #203.