Skip to content

su_tagarg: fall back to the va_list copy path under AddressSanitizer #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
garacil wants to merge 1 commit into
base: master
Choose a base branch
from
Open

su_tagarg: fall back to the va_list copy path under AddressSanitizer #332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions libsofia-sip-ua/su/sofia-sip/su_tagarg.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,28 @@ typedef struct {
*
* @hideinitializer
*/
#if SU_HAVE_TAGSTACK

/* AddressSanitizer instruments the stack so the SU_HAVE_TAGSTACK fast path -
* which reads the variable arguments directly off the caller's stack via
* TAG_NEXT(&(v) + 1) - is walked below the ta stack object when the tag list is
* traversed (t_next -> t_next_next follows the raw stack pointer), which ASan
* correctly reports as a stack-buffer-underflow. Fall back to the portable
* va_list copy path (tl_vlist) under ASan. */
#if defined(__SANITIZE_ADDRESS__)
# define SU_TAGARG_ASAN 1
#elif defined(__has_feature)
# if __has_feature(address_sanitizer)
# define SU_TAGARG_ASAN 1
# endif
#endif

#if SU_HAVE_TAGSTACK && !defined(SU_TAGARG_ASAN)
# define SU_TAGARG_USE_TAGSTACK 1
#else
# define SU_TAGARG_USE_TAGSTACK 0
#endif

#if SU_TAGARG_USE_TAGSTACK
/* All arguments are saved into stack (left-to-right) */
#define ta_start(ta, t, v) \
do { \
Expand Down Expand Up @@ -188,7 +209,7 @@ typedef struct {
*
* @hideinitializer
*/
#if SU_HAVE_TAGSTACK
#if SU_TAGARG_USE_TAGSTACK
#define ta_end(ta) (va_end((ta).ap), (ta).tl->t_tag = NULL)
#else
#define ta_end(ta) \
Expand Down