nta/s2sip test: fix dead tcp/tls transport fallback (duplicated if condition)#329
Open
garacil wants to merge 1 commit into
Open
nta/s2sip test: fix dead tcp/tls transport fallback (duplicated if condition)#329garacil wants to merge 1 commit into
garacil wants to merge 1 commit into
Conversation
The transport-selection fallback used an else-if chain that re-tests the same condition: if (tport == NULL) tport = udp; else if (tport == NULL) tport = tcp; else if (tport == NULL) tport = tls; Once the first if runs, the else-if branches are unreachable (an else only runs when tport was non-NULL, then re-checks == NULL, which is false), so the tcp/tls fallbacks were dead code. Use sequential if statements, matching the fallthrough style already used for the sut/tls selection a few lines above. Fixes freeswitch#99.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transport-selection fallback in
s2sip.cused anelse ifchain that re-tests the same condition:Once the first
ifruns, theelse ifbranches are unreachable (anelseonly runs whentportwas non-NULL, and then re-checks== NULL, which is false), so the tcp/tls fallbacks were dead code. This switches to sequentialifstatements, matching the fallthrough style already used for the sut/tls selection a few lines above.Fixes #99.