sip_parser: fail closed if the message separator cannot be allocated#328
Open
garacil wants to merge 1 commit into
Open
sip_parser: fail closed if the message separator cannot be allocated#328garacil wants to merge 1 commit into
garacil wants to merge 1 commit into
Conversation
sip_complete_message() created the trailing separator with sip_separator_create() but never checked the result before the multipart path dereferences sip->sip_separator->sep_common. If the allocation fails the separator stays NULL and the message is dereferenced through a NULL pointer. Return -1 (the function's existing error contract) when the separator cannot be allocated. Fixes freeswitch#312.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sip_complete_message()created the trailing message separator withsip_separator_create()but never checked the result before the multipart path dereferencessip->sip_separator->sep_common. If the allocation fails the separator staysNULLand the message is dereferenced through a NULL pointer.This returns
-1— the function's existing error contract — when the separator cannot be allocated, fail-closed before any dereference. No behavior change on the success path; no ABI/API impact.Fixes #312.