Repository navigation
refactor(cdb): clarify wording + simplify testing - #45
Merged
ShaunSHamilton merged 4 commits intoNov 10, 2026
Merged
ShaunSHamilton merged 4 commits into
ShaunSHamilton merged 4 commits into
Conversation
This clarifies a few points I found confusing
sqlx already implicitly requires unique versions since migration will fail if there are duplicates. Since other tests include migrations we still have coverage.
Silently ignoring tests can be confusing: ideally tests should either pass or fail. Now devs will get a failure and a hint about how to fix it.
ShaunSHamilton
approved these changes
Nov 10, 2026
Member
|
All fun and games, until that path does exist... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)These were all things that tripped me up when trying to understand the tests and understand what was being tested.
Explanations in commit messages.