Repository navigation
1C: Pid Concepts - #392
Open
Adrianamm wants to merge 6 commits into
Open
1C: Pid Concepts#392Adrianamm wants to merge 6 commits into
Adrianamm wants to merge 6 commits into
Conversation
github-actions
Bot
added
Learning Course
|
🌐 Preview URL: https://pr-392.frcsoftware.org Changed pages |
roboteer5291
requested changes
Nov 2, 2026
roboteer5291
left a comment
roboteer5291
left a comment
Collaborator
There was a problem hiding this comment.
Would recommend changing the 1C overview page to use the term "output" consistently with the page added here.
There's also some really odd sentences broken over multiple lines (that aren't inside html blocks) that I feel like should be combined to make it easier to make suggestions on github and prevent diff explosion
|
|
||
| A feedback controller uses sensors and equations to figure out what the mechanism is currently doing, | ||
| and correct the mechanism's actions so the mechanism moves to where we want it to be. | ||
| What the mechanism is currently doing, the information from the sensors, is called the **output**. |
Collaborator
There was a problem hiding this comment.
Read this again. It's not the output.
Co-authored-by: Andrew Haselton <13470989+roboteer5291@users.noreply.github.com>
DylanB5402
reviewed
Nov 5, 2026
DylanB5402
left a comment
DylanB5402
left a comment
Member
There was a problem hiding this comment.
left a number of comments on the first half, will probably give this another pass later
|
|
||
| First we start off with tuning P. | ||
| As P increases, the output overshoots and oscillates. | ||
| Overshooting is when the output passes the setpoint, and oscillating means it passes the setpoint repeatedly. |
Member
There was a problem hiding this comment.
Might be good to explain the back and forth behavior of oscillation here, though I do think this is better explained visually.
Co-authored-by: Dylan Barva <d.barva5402@gmail.com>
DylanB5402
reviewed
Nov 7, 2026
DylanB5402
left a comment
DylanB5402
left a comment
Member
There was a problem hiding this comment.
Another set of review, mostly small grammatical things. This is probably good to just merge once that's taken care of, not sure if there are any higher level things about this section that we want to hash out
DylanB5402
reviewed
Nov 7, 2026
DylanB5402
left a comment
DylanB5402
left a comment
Member
There was a problem hiding this comment.
also pls rebase from main, the broken FIRSTInspires blog link is failing CI
Co-authored-by: Dylan Barva <d.barva5402@gmail.com>
github-actions
Bot
added
REV
Adrianamm
removed
Backend
github-actions
Bot
added
Backend
github-actions
Bot
added
the
Resources
github-actions
Bot
removed
REV
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What changed?
Introduces the concept of PID for 1C. No code stuff yet, that's another PR
Meta
Merge checklist: