Skip to content

CodeRabbit review findings #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErikBooijFR merged 2 commits into from
Aug 12, 2026
Merged

CodeRabbit review findings #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdd41db
Exit 125 on flag parsing errors
ErikBooijFR Aug 11, 2026
c90d9fa
Enforce Go 1.26.5 as the minimum version
ErikBooijFR Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ itself uses:

## Building from source

This project uses [Go modules](https://go.dev/blog/using-go-modules) and requires Go 1.26+.
This project uses [Go modules](https://go.dev/blog/using-go-modules) and requires Go 1.26.5+.

```bash
go mod download
Expand Down
4 changes: 1 addition & 3 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
module env-aws-params

go 1.26

toolchain go1.26.5
go 1.26.5

require (
github.com/aws/aws-sdk-go-v2 v1.41.7
Expand Down
5 changes: 5 additions & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@ func main() {
Flags: cliFlags(),
Action: action,
StopOnNthArg: &stopOnFirstArg,
// Flag parsing errors never reach action, so they are mapped to
// the documented usage-error exit code here.
OnUsageError: func(_ context.Context, _ *cli.Command, err error, _ bool) error {
return cli.Exit(errorPrefix(err), 125)
},
}
if err := cmd.Run(context.Background(), os.Args); err != nil {
log.Fatal(err)
Expand Down