Repository navigation
[trial, do not merge] CI checks + pyogrio fix - #3
Closed
srikoushik wants to merge 3 commits into
Closed
srikoushik wants to merge 3 commits into
srikoushik wants to merge 3 commits into
Conversation
srikoushik
force-pushed
the
ci-trial-pyogrio
branch
3 times, most recently
from
November 4, 2026 06:43
d3328a0 to
6ddd21a
Compare
Nothing runs on pull requests today, and dev already has 38 failing tests and 137 ruff findings, so a new problem is hard to spot by eye. core-stack-org#1419 and core-stack-org#1420 show the cost: a repeated dict key (ruff F601) and then a regression that an existing test caught, both merged unnoticed. Add a "Checks" workflow for pull requests into dev and main. Each job compares the pull request with its target branch and fails only on what the pull request adds, so existing problems don't block anyone and no list of known failures has to be maintained: - lint: ruff 0.17.3 with bug-catching rules only (syntax errors, repeated dict keys, redefinitions, undefined names), counted per file and rule; - tests: runs in the published ghcr.io/core-stack-org/core-stack-backend image with a Postgres service, generates migrations the way database-init.sh does, runs `manage.py check`, then the suite on both branches, and fails if a test fails only on the pull request. Settings get placeholder values and a throwaway Fernet key; no secrets are needed. The workflow only reports a status; whether it blocks merging is a branch-protection setting for the maintainers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
srikoushik
force-pushed
the
ci-trial-pyogrio
branch
from
November 4, 2026 07:13
a52afbd to
2c2272e
Compare
Author
|
Trial finished; the workflow is proposed upstream in core-stack-org#1447. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary PR in the fork to trial the CI workflow together with the pyogrio fix. Will be closed after the run.