avoid shared typing marker ownership with foxglove-sdk - #165
Merged
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
mguida22
changed the title
mguida22
marked this pull request as ready for review
September 28, 2026 23:12
brookfxg
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the client's
py.typedmarker fromfoxglove/tofoxglove/client/so uninstalling the client no longer deletes the marker shared with foxglove-sdk. Runtime APIs and imports are unchanged.Upgrade caveat: If both packages are already installed, reinstall
foxglove-sdkafter upgrading the client: uninstalling the old client can still remove the shared marker.Validated wheel/sdist contents, both installation orders, imports, and uninstalls. Companion to foxglove/foxglove-sdk#1482.