Skip to content

Return episode recording locations #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mo-Elshenawy1 merged 1 commit into from
Sep 29, 2026
Merged

Return episode recording locations #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions foxglove/client/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2148,6 +2148,7 @@ def _episode_recording_dict(recording):
return {
"id": recording["id"],
"path": recording["path"],
"location": recording.get("location"),
"start": arrow.get(recording["start"]).datetime,
"end": arrow.get(recording["end"]).datetime,
"device_id": recording.get("deviceId"),
Expand Down
1 change: 1 addition & 0 deletions tests/test_datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ def test_dataset_version_methods():
assert version["version_number"] == 1
assert version["has_missing_recordings"] is False
assert episodes.items[0]["episode"]["id"] == "ep_1"
assert episodes.items[0]["episode"]["recordings"][0]["location"] is None
assert comparison["changes"][0]["change"] == "added"
assert "has_missing_recordings" not in comparison["changes"][0]
assert comparison["next_cursor"] == "next"
Expand Down
5 changes: 5 additions & 0 deletions tests/test_episodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ def _episode_json(episode_id="ep_1", *, include_recordings=False):
{
"id": "rec_1",
"path": "run.mcap",
"location": {"bucket": "robot-logs", "path": "fleet/run.mcap"},
"start": NOW.isoformat(),
"end": NOW.replace(minute=1).isoformat(),
"deviceId": "dev_1",
Expand Down Expand Up @@ -94,6 +95,10 @@ def test_get_episodes_maps_response_and_filters():
assert episodes.items[0]["start_time"] == NOW
assert episodes.items[0]["metadata"]["nestedValue"] == {"keepMe": True}
assert episodes.items[0]["recordings"][0]["device_id"] == "dev_1"
assert episodes.items[0]["recordings"][0]["location"] == {
"bucket": "robot-logs",
"path": "fleet/run.mcap",
}
assert episodes.items[0]["recordings"][0]["resolvable"] is True
assert episodes.items[0]["has_missing_recordings"] is False
assert responses.calls[0].request.params == {
Expand Down
Loading