Skip to content

fix(table/regexp): rename expand_replaceholders to expand_placeholders - #902

Merged
foxcpp merged 1 commit into
foxcpp:masterfrom
troioi-vn:fix/regexp-expand-placeholders
Nov 12, 2026
Merged

foxcpp merged 1 commit into
foxcpp:masterfrom
troioi-vn:fix/regexp-expand-placeholders

Conversation

@troioi-vn

Copy link
Copy Markdown
Contributor

The documented expand_placeholders directive currently fails with "unexpected directive" because the implementation reads expand_replaceholders.

As agreed in #896, accept the documented name and keep the old spelling working with a deprecation warning. Expansion still defaults to yes. This also corrects the directive name in the Vim syntax file and adds tests for expansion behavior and invalid configuration.

Validation: go test ./... and golangci-lint run passed.

Together with #898, this addresses both problems in #896.

Fixes #896

Description drafted with Claude Code, reviewed by me.

The old name still works for now and logs a deprecation warning.

Fixes foxcpp#896

Assisted-By: Claude Code (claude-opus-5-5)
Signed-off-by: troioi-vn <chusovitin@gmail.com>
@foxcpp

foxcpp commented Nov 12, 2026

Copy link
Copy Markdown
Owner

I am not a big fan of Callback duplicating config.Map code but we don't have a proper solution for deprecating/renaming of configuration directives so let's merge this for now.

@github-project-automation github-project-automation Bot moved this from First Feedback Needed to Approved in Maddy Mail Server PR Review Nov 12, 2026
@foxcpp
foxcpp merged commit 765744d into foxcpp:master Nov 12, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Maddy Mail Server PR Review Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

docs: table.chain +tag example doesn't parse, and table.regexp documents the wrong directive name

2 participants