Repository navigation
fix(table/regexp): rename expand_replaceholders to expand_placeholders - #902
Merged
Merged
Conversation
The old name still works for now and logs a deprecation warning. Fixes foxcpp#896 Assisted-By: Claude Code (claude-opus-5-5) Signed-off-by: troioi-vn <chusovitin@gmail.com>
Owner
|
I am not a big fan of |
foxcpp
approved these changes
Nov 12, 2026
foxcpp
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented
expand_placeholdersdirective currently fails with "unexpected directive" because the implementation readsexpand_replaceholders.As agreed in #896, accept the documented name and keep the old spelling working with a deprecation warning. Expansion still defaults to
yes. This also corrects the directive name in the Vim syntax file and adds tests for expansion behavior and invalid configuration.Validation:
go test ./...andgolangci-lint runpassed.Together with #898, this addresses both problems in #896.
Fixes #896
Description drafted with Claude Code, reviewed by me.