Repository navigation
auth/pass_table: Return an error for malformed argon2 hashes instead of panicking - #891
Merged
Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #888. Ports the
verifyArgon2fix from SCys/maddy@1a15f4153 with a regression test.verifyArgon2indexesparts[0..4]without checking how many fieldsSplitNreturned, so a storedargon2:hash with fewer than five:-separated fields (truncated row, hand-edited table, etc.) panics with an index out of range during AUTH. A hash withtimeorthreadsset to 0 also panics, insideargon2.IDKey.This adds a field count check, plus a check for zero
time/threads, and returns a "malformed hash string" error in both cases like the other parse failures in that function.Tested with
go test ./internal/auth/.... The newTestVerifyArgon2_Malformedpanics on master and passes with this change.