Skip to content

feat: log specific diagnostics for unknown authentication usernames - #890

Merged
foxcpp merged 1 commit into
foxcpp:masterfrom
mvanhorn:fix/649-authentication-failure-log-details
Nov 7, 2026
Merged

foxcpp merged 1 commit into
foxcpp:masterfrom
mvanhorn:fix/649-authentication-failure-log-details

Conversation

@mvanhorn

@mvanhorn mvanhorn commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Why

Authentication logs do not distinguish an unknown username from other credential failures, making account typos harder to diagnose.

Summary

Attach a specific reason, provider identity, and mapped username when a credentials-table entry is missing. Preserve generic client errors and report table lookup errors before checking for a missing entry.

Testing

Gofmt -l internal/auth/pass_table/table.go internal/auth/pass_table/table_test.go reported no formatting changes. Go vet ./internal/auth/pass_table/... completed without diagnostics. Go test ./internal/auth/pass_table/... passed. Repo_lint ran three times with no output shown. The tests in internal/auth/pass_table/table_test.go fail without the fix in the maddy change (checked by reverting the source changes). The changed test internal/auth/pass_table/table_test.go did not run here: no test runner for it was available.

Fixes #649

Attach a specific reason, provider identity, and mapped username when a
credentials-table entry is missing. Preserve generic client errors and
report table lookup errors before checking for a missing entry.

Fixes foxcpp#649
@github-project-automation github-project-automation Bot moved this to First Feedback Needed in Maddy Mail Server PR Review Nov 6, 2026
@foxcpp
foxcpp merged commit b53b331 into foxcpp:master Nov 7, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from First Feedback Needed to Merged in Maddy Mail Server PR Review Nov 7, 2026
@mvanhorn

mvanhorn commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for merging this, @foxcpp. Having the missing credentials-table entry show up as its own reason in the auth logs should make username typos much quicker to track down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Error Message should Validate Username is in Domain for Authentication Error

2 participants