Repository navigation
feat(endpoint/smtp): Add rdns_lookup option - #889
Merged
Merged
Conversation
… DNS lookups Fixes foxcpp#150
foxcpp
approved these changes
Nov 7, 2026
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
rdns_lookupboolean to the smtp/submission/lmtp endpoint (defaultyes, so nothing changes unless it is set).With
rdns_lookup nono PTR query is sent for connecting clients.Conn.RDNSNamestays nil, whichrequire_matching_rdnsalready treats as "rDNS lookup is disabled", and theReceivedheader omits the name. Documented in the endpoint reference.Test added for the disabled case;
go test ./internal/endpoint/smtp/passes.Fixes #150