fix: [BACKPORT] restore touch pass-through for no-overlay surveys (1.1.1) - #47
Merged
Merged
Conversation
The card-geometry probe matched `#fbjs [role="dialog"][aria-modal="true"]`. The surveys runtime now sets `aria-modal` only when a survey has a backdrop, so the selector matched nothing in exactly the no-overlay case the pointer mask exists for. `fbCardRect()` returned null forever, the reported rect stayed null, and `_RenderPointerMask` rejected pointers across the whole WebView — the survey card became untappable. Match on `role="dialog"` alone. It is on the card in every overlay mode, and scoping to `#fbjs` still keeps the probe off the full-screen wrapper. The runtime is loaded from the server at render time, so this reached every host on a current server without an SDK release. Nothing here can be covered by a test: the probe is a JS string inside Dart that the widget tests never execute (they inject the geometry event directly). The broken state was reproduced by hand on a local host app; the fix needs the same check before merge. (cherry picked from commit 4b67b0e)
pandeymangg
changed the title
|
Dhruwang
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #46 onto
release/1.1, plus the 1.1.1 bump.mainalso carries the embedded-data feature (#44), which is a new public API and so a minor. Shipping the touch fix on its own from the release branch keeps this a patch.Contents
4b67b0echerry-picked — applied clean, one file (survey_html.dart), no conflictsLocal checks: format-check, analyze, 308 SDK tests, 6 playground tests, publish dry-run — all clean.
After merge: tag
1.1.1onrelease/1.1and push to trigger the publish workflow, then mergerelease/1.1back intomainwith a merge commit (not squash) so main stays in sync.