Skip to content

fix: restore touch pass-through for no-overlay surveys #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dhruwang merged 1 commit into from
Sep 3, 2026
Merged

fix: restore touch pass-through for no-overlay surveys #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions packages/formbricks/lib/src/widgets/survey_html.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,12 +162,18 @@ String buildSurveyHtml(SurveyHtmlOptions options) {
var fbGeometryRaf = null;
var fbGeometryStable = 0;
function fbCardRect() {
// The survey card is the single modal dialog the runtime renders inside
// its #fbjs container (survey-container.tsx). Scoped + both attributes
// so we never grab the full-screen #fbjs wrapper (that would defeat
// box-none) or a future nested dialog. querySelector returns the
// outermost match in document order, i.e. the card itself.
var el = document.querySelector('#fbjs [role="dialog"][aria-modal="true"]');
// The survey card is the single dialog the runtime renders inside its
// #fbjs container (survey-container.tsx). Scoped to #fbjs so we never
// grab the full-screen wrapper (that would defeat box-none);
// querySelector returns the outermost match in document order, i.e.
// the card itself.
//
// Deliberately NOT matched on aria-modal. The runtime sets that
// attribute only when the survey has a backdrop (ENG-2304), so
// requiring it matched nothing in exactly the no-overlay case this
// mask exists for -- the rect stayed null and the card became
// untappable. Match on role alone: it is on the card in every mode.
var el = document.querySelector('#fbjs [role="dialog"]');
if (!el) return null;
var r = el.getBoundingClientRect();
if (r.width <= 0 || r.height <= 0) return null;
Expand Down