Skip to content

UPSTREAM.md records the holder upstream's LICENCE leaves out - #136

Merged
closer-claudio merged 1 commit into
mainfrom
claudio/20261116-upstream-notices
Nov 17, 2026
Merged

closer-claudio merged 1 commit into
mainfrom
claudio/20261116-upstream-notices

Conversation

@closer-claudio

Copy link
Copy Markdown
Contributor

🎯 Why

Upstream's LICENCE leaves out a holder whose code the package compiles: openbsd-compat/freezero.c and openbsd-compat/recallocarray.c are Otto Moerbeek's, under ISC, whose notice is to "appear in all copies". Both are compiled on macOS, which has neither function, and LICENCE names four holders of its ISC-style compatibility code, not him (LICENCE, freezero.c, recallocarray.c).

UPSTREAM.md is this repository's record of what differs from upstream, and it had no row for this.

🛠️ What

One row in "Changes upstream does not have": what LICENCE leaves out, and what the package ships instead, share/licenses/NOTICES, generated by notices.sh from the headers of the sources it compiles (#120).

🧪 How

  • The pinned 10.6p2 sources: LICENCE has no line naming him; both files carry his copyright.
  • A CI-built darwin arm64 package's share/licenses/NOTICES names him; test-binary.sh fails a package whose NOTICES does not.
  • just lint green. Documentation only: no code, script or workflow changes.

📝 Notes

Not reported upstream, by decision.

openbsd-compat/freezero.c and openbsd-compat/recallocarray.c are Otto
Moerbeek's, under ISC, and are compiled on macOS; upstream's LICENCE
names four holders of its ISC-style compatibility code and not him. The
package answers it by generating share/licenses/NOTICES from the headers
of what it compiles (notices.sh), and test-binary.sh fails a package
whose NOTICES does not name him.

A defect of an upstream this repository carries belongs in its own
record of what differs from upstream; this one was recorded only in
limen's book, which is for what is not forked.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Signed-off-by: closer-claudio <claudio@farcloser.world>
@closer-claudio closer-claudio added the internal Changes nothing for a consumer: tooling, CI, maintainers' docs; left out of the notes label Nov 16, 2026
@closer-claudio

Copy link
Copy Markdown
Contributor Author

Reviewed at 771f9b9

1 similar comment
@closer-claudio

Copy link
Copy Markdown
Contributor Author

Reviewed at 771f9b9

@closer-claudio
closer-claudio merged commit ef44d88 into main Nov 17, 2026
8 checks passed
@closer-claudio
closer-claudio deleted the claudio/20261116-upstream-notices branch November 17, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Changes nothing for a consumer: tooling, CI, maintainers' docs; left out of the notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants