Repository navigation
UPSTREAM.md records the holder upstream's LICENCE leaves out - #136
Merged
Merged
Conversation
openbsd-compat/freezero.c and openbsd-compat/recallocarray.c are Otto Moerbeek's, under ISC, and are compiled on macOS; upstream's LICENCE names four holders of its ISC-style compatibility code and not him. The package answers it by generating share/licenses/NOTICES from the headers of what it compiles (notices.sh), and test-binary.sh fails a package whose NOTICES does not name him. A defect of an upstream this repository carries belongs in its own record of what differs from upstream; this one was recorded only in limen's book, which is for what is not forked. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: closer-claudio <claudio@farcloser.world>
closer-claudio
enabled auto-merge
November 16, 2026 08:53
Contributor
Author
|
Reviewed at 771f9b9 |
1 similar comment
Contributor
Author
|
Reviewed at 771f9b9 |
apostasie
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Why
Upstream's
LICENCEleaves out a holder whose code the package compiles:openbsd-compat/freezero.candopenbsd-compat/recallocarray.care Otto Moerbeek's, under ISC, whose notice is to "appear in all copies". Both are compiled on macOS, which has neither function, andLICENCEnames four holders of its ISC-style compatibility code, not him (LICENCE, freezero.c, recallocarray.c).UPSTREAM.mdis this repository's record of what differs from upstream, and it had no row for this.🛠️ What
One row in "Changes upstream does not have": what
LICENCEleaves out, and what the package ships instead,share/licenses/NOTICES, generated bynotices.shfrom the headers of the sources it compiles (#120).🧪 How
LICENCEhas no line naming him; both files carry his copyright.share/licenses/NOTICESnames him;test-binary.shfails a package whoseNOTICESdoes not.just lintgreen. Documentation only: no code, script or workflow changes.📝 Notes
Not reported upstream, by decision.