Repository navigation
lint: gosec leaves the backlog - #89
Merged
Merged
Conversation
gosec was exempted in git/commits.go at enrolment, for eight launches of git with arguments that are not constants. The package has since come to launch git in one place, command, and that is the one finding left: G204, a subprocess launched with a variable. It is right as it is. The program is the constant git. Its arguments are the subcommands this file writes, the commits git itself named, and the range the operator gave: by --range, or by the variables of their CI that the command reads (TRAVIS_COMMIT_RANGE, TRAVIS_COMMIT, GITHUB_SHA). It reaches git as it would if they had typed it there. The finding is silenced inline, by its rule, saying so. No behaviour changes. For #37. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: closer-claudio <claudio@farcloser.world>
closer-claudio
enabled auto-merge
November 16, 2026 02:12
Author
|
Reviewed at 1d6ec9b |
1 similar comment
Author
|
Reviewed at 1d6ec9b |
apostasie
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Why
gosecwas exempted ingit/commits.gowhen the repository came under the lint baseline, for eight launches of git with arguments that are not constants (#37). The package has since come to launch git in one place,command, and that is the one finding left: G204, a subprocess launched with a variable.🛠️ What
.lint-go.yaml:gosecleaves the backlog.git/commits.go: the finding is right as it is, and is silenced inline, by its rule, with the reason. The program is the constantgit. Its arguments are the subcommands this file writes, the commits git itself named, and the range the operator gave: by--range, or by the variables of their CI that the command reads (TRAVIS_COMMIT_RANGE,TRAVIS_COMMIT,GITHUB_SHA). It reaches git as it would if they had typed it there.🧪 How
V:
just lintandjust testgreen on the branch (62 tests).📝 Notes
For #37.