Repository navigation
The lint backlog no longer exempts the runner from three linters that find nothing there - #85
Merged
Conversation
The backlog block exempted validate/runner.go from forbidigo (7 findings at enrolment), varnamelen (2) and err113 (1). The runner has since stopped printing (it reports through Runner.Report), its errors are wrapped, and the short names are gone: with the three exemptions removed, `just do lint go` finds nothing in the file. gocognit's one finding there is still found and stays. The entry for cmd/git-validation/main.go stays whole: taken out, its five findings come back (forbidigo 3, gocognit 1, revive 1). For #37. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: closer-claudio <claudio@farcloser.world>
closer-claudio
enabled auto-merge
November 15, 2026 19:45
Author
|
Reviewed at a5cbf6f |
apostasie
approved these changes
Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Why
The onboarding lint backlog in
.lint-go.yamlstill exemptedvalidate/runner.gofrom three linters that find nothing in it any more:forbidigo(7 findings at enrolment),varnamelen(2) anderr113(1). The runner has since stopped printing (it reports throughRunner.Report), its errors are wrapped, and the short names are gone. An exemption with nothing behind it would let the next such finding in unseen.For #37, the backlog.
🛠️ What
.lint-go.yaml: the three exemptions forvalidate/runner.gogo; the file's count drops from 11 to 1 (gocognit, still found, stays).🧪 How
lint: the backlog stops naming what validate/runner.go no longer hasjust lintandjust testpass on macOS arm64 (57 tests): with the three exemptions removed,just do lint gofinds nothing in the file.cmd/git-validation/main.gotaken out as well, its five findings come back (forbidigo3,gocognit1,revive1), so the lint does look at what the block stops exempting. That entry is untouched.📝 Notes