Repository navigation
The short-subject rule names its two lengths - #84
Merged
Merged
Conversation
mnd was off for rules/shortsubject/shortsubject.go as part of the onboarding backlog. It finds the two numbers the rule compares a subject with: 90, which a subject must stay under, and 72, which it is better kept within. They are constants now, named for what they are. The rule decides nothing differently: validate/contract_test.go holds both boundaries (72, 73, 89, 90) and passes unchanged. For #37. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: closer-claudio <claudio@farcloser.world>
closer-claudio
enabled auto-merge
November 15, 2026 19:34
Author
|
Reviewed at 3087558 |
apostasie
approved these changes
Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Why
mndwas switched off forrules/shortsubject/shortsubject.goas part of the onboarding lint backlog. It finds the two numbers the rule compares a subject with, written bare in the conditions: 90, which a subject must stay under, and 72, which it is better kept within.For #37, the backlog, worked off one linter per pull request.
🛠️ What
rules/shortsubject/shortsubject.go: the two numbers are the constantslimitandpreferred..lint-go.yaml:mndleaves the backlog block for that file; its count is lowered.🧪 How
lint: mnd leaves the backlog, the subject's two lengths are namedjust lintandjust testpass on macOS arm64 (57 tests).validate/contract_test.goholds both boundaries (72, 73, 89, 90) and is untouched.📝 Notes