Skip to content

The short-subject rule names its two lengths - #84

Merged
closer-claudio merged 1 commit into
mainfrom
claudio/20261115-lint-mnd
Nov 15, 2026
Merged

closer-claudio merged 1 commit into
mainfrom
claudio/20261115-lint-mnd

Conversation

@closer-claudio

Copy link
Copy Markdown

🎯 Why

mnd was switched off for rules/shortsubject/shortsubject.go as part of the onboarding lint backlog. It finds the two numbers the rule compares a subject with, written bare in the conditions: 90, which a subject must stay under, and 72, which it is better kept within.

For #37, the backlog, worked off one linter per pull request.

🛠️ What

  • rules/shortsubject/shortsubject.go: the two numbers are the constants limit and preferred.
  • .lint-go.yaml: mnd leaves the backlog block for that file; its count is lowered.

🧪 How

  1. lint: mnd leaves the backlog, the subject's two lengths are named
    • V: just lint and just test pass on macOS arm64 (57 tests).
    • V: the rule decides nothing differently: validate/contract_test.go holds both boundaries (72, 73, 89, 90) and is untouched.
    • U: Linux and Windows, left to CI.

📝 Notes

  • Nothing changes for someone who runs the command or imports the packages.

mnd was off for rules/shortsubject/shortsubject.go as part of the
onboarding backlog. It finds the two numbers the rule compares a subject
with: 90, which a subject must stay under, and 72, which it is better
kept within. They are constants now, named for what they are.

The rule decides nothing differently: validate/contract_test.go holds
both boundaries (72, 73, 89, 90) and passes unchanged.

For #37.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Signed-off-by: closer-claudio <claudio@farcloser.world>
@closer-claudio closer-claudio added the internal Changes nothing for a consumer: tooling, CI, maintainers' docs; left out of the notes label Nov 15, 2026
@closer-claudio

Copy link
Copy Markdown
Author

Reviewed at 3087558

@closer-claudio
closer-claudio merged commit dda3941 into main Nov 15, 2026
14 checks passed
@closer-claudio
closer-claudio deleted the claudio/20261115-lint-mnd branch November 15, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Changes nothing for a consumer: tooling, CI, maintainers' docs; left out of the notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants