Repository navigation
Errors from git and the file system say what was being done - #83
Merged
Merged
Conversation
wrapcheck was off for git/commits.go and validate/runner.go as part of the onboarding backlog. It finds nine errors returned as another package gave them: git's exit status from `git version`, `git log --check` and `git show`, and the working directory, the chdir and the commit lookups of the runner. Each now says what was being done: "listing the commits of <range>", "entering <dir>", "git show <commit>". Wrapping `git.Check`'s error would have broken the dangling-whitespace rule, which told git's "whitespace errors" exit from a failure by the error's text (`err.Error() == "exit status 2"`). The rule now reads the exit status from the error (`errors.As` to `*exec.ExitError`), which the wrap keeps. No test held the rule's message: the command's contract test now does, and it fails on the rule as it was once the error is wrapped. The backlog's counts for the two files are lowered by what left it. For #37. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: closer-claudio <claudio@farcloser.world>
closer-claudio
enabled auto-merge
November 15, 2026 11:48
Author
|
Reviewed at 2999bba |
apostasie
approved these changes
Nov 15, 2026
closer-claudio
added a commit
that referenced
this pull request
Nov 16, 2026
The table of what upstream does not have stops at the shallow-clone refusal. Three later changes a user of the command can see have no row: QUIET in the environment no longer quiets it (#81), errors say what was being done (#83), and a run can be stopped (#86). Upstream's main is still the commit forked from: the comparison of a8d4555 with main, asked of GitHub today, is zero commits ahead. The "Reviewed through" line takes today's date. For #50. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: closer-claudio <claudio@farcloser.world>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Why
wrapcheckwas switched off forgit/commits.goandvalidate/runner.goas part of the onboarding lint backlog. It finds nine errors returned exactly as another package gave them, so a failure said "exit status 128" or "no such file or directory" with nothing about what was being done.For #37, the backlog, worked off one linter per pull request. This is the first.
🛠️ What
.lint-go.yaml:wrapcheckleaves the backlog block for the two files; their counts are lowered.git/commits.go,validate/runner.go: the nine errors are wrapped with what was being done ("listing the commits of ", "entering ", "git show ").rules/danglingwhitespace/rule.go: the rule told git's "whitespace errors" exit from a failure by the error's text (err.Error() == "exit status 2"), which a wrapped error no longer equals. It now reads the exit status from the error witherrors.As.cmd/git-validation/contract_test.go:TestContractWhitespaceErrorsAreNamedholds the rule's message, which no test did.🧪 How
lint: wrapcheck leaves the backlog, its nine errors wrappedjust lintandjust testpass on macOS arm64 (57 tests, unit and race).git.Check's error is wrapped.📝 Notes
errors.Isanderrors.Assee the same errors as before.