Skip to content

fix: fail closed when review analysis omits its plan#149

Closed
eshulman2 wants to merge 1 commit into
mainfrom
fix/review-analysis-missing-plan
Closed

fix: fail closed when review analysis omits its plan#149
eshulman2 wants to merge 1 commit into
mainfrom
fix/review-analysis-missing-plan

Conversation

@eshulman2

Copy link
Copy Markdown
Collaborator

Summary

  • require review analysis to produce a non-empty review-plan artifact
  • treat a missing or empty plan as an implement_review failure so normal retry/error handling applies
  • preserve the explicit no-action marker as the only successful no-op
  • add regression coverage for missing and empty plans

Why

During AISOS-2157, the analysis agent correctly analyzed all review feedback but ended before writing the required plan. Forge interpreted the missing file as no actionable feedback and silently returned to the human-review gate.

Validation

Focused Ruff checks pass. All 26 implement-review unit tests pass.

@eshulman2

Copy link
Copy Markdown
Collaborator Author

Closing this narrow fix for now. Robustly distinguishing missing analysis output from an intentional no-op requires a shared typed artifact contract rather than parsing sentinel text or Markdown structure. Tracking the broader design and migration in #150.

@eshulman2 eshulman2 closed this Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant