fix: fail closed when review analysis omits its plan#149
Closed
eshulman2 wants to merge 1 commit into
Closed
Conversation
b0ac752 to
df82702
Compare
Collaborator
Author
|
Closing this narrow fix for now. Robustly distinguishing missing analysis output from an intentional no-op requires a shared typed artifact contract rather than parsing sentinel text or Markdown structure. Tracking the broader design and migration in #150. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
During AISOS-2157, the analysis agent correctly analyzed all review feedback but ended before writing the required plan. Forge interpreted the missing file as no actionable feedback and silently returned to the human-review gate.
Validation
Focused Ruff checks pass. All 26 implement-review unit tests pass.