fix: metadata with ampersand (%26) never syncs in source tracking @W-21360609@#862
Open
WillieRuemmele wants to merge 3 commits into
Open
fix: metadata with ampersand (%26) never syncs in source tracking @W-21360609@#862WillieRuemmele wants to merge 3 commits into
WillieRuemmele wants to merge 3 commits into
Conversation
…dElements @W-21360609@ syncSpecifiedElements used decodeURI() as fallback when matching metadata keys, but decodeURI does not decode %26 (ampersand). This caused metadata files with & in their names (stored as %26 on disk) to never have lastRetrievedFromServer updated, making them perpetually appear as needing retrieve. Replace the raw decodeURI fallback with the existing getSourceMember() method which properly handles all encoded characters via decodeURIComponent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
syncSpecifiedElements()useddecodeURI()as fallback when matching metadata keys, butdecodeURIdoes not decode%26(ampersand) — onlydecodeURIComponentdoes&in their names (stored as%26on disk) to never havelastRetrievedFromServerupdated, making them perpetually appear as needing retrievedecodeURIfallback with the existinggetSourceMember()private method which already handles all encoded characters properly viagetDecodedKeyIfSourceMembersHas()Fixes forcedotcom/cli#3504
Work Item
@W-21360609@: CLI: Metadata files with ampersand don't get properly updated in source tracking
Proof of Work
Test plan
&in the name (e.g. "Legal & Compliance Layout") syncs correctly after retrievesf project retrieve previewno longer shows the file as needing retrieve after a successful pull%2E(dot) encoding cases still work (covered by existing tests).forceignorecorrectly ignores files with encoded special characters