Library construction changes - #31
Open
mj-mueller wants to merge 4 commits into
Open
mj-mueller wants to merge 4 commits into
mj-mueller wants to merge 4 commits into
Conversation
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Moritz Müller <m***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request. |
mj-mueller
force-pushed
the
libraryChanges
branch
from
July 8, 2019 11:55
0efe547 to
10d275f
Compare
The only library that will be creartred is 'SiteGenesisSharedLibrary'. That library consists of the default SiteGenesis library plus generated comdagen folders and contentassets. Signed-off-by: Moritz Mueller <m.mueller@salesforce.com>
If the summary content asset is rendered the home-main slot will display it. Therefore slots.xml are rendered by its own template. Tests are not finished by now and currently fail. Signed-off-by: Moritz Mueller <m.mueller@salesforce.com>
Signed-off-by: Moritz Mueller <m.mueller@salesforce.com>
Signed-off-by: Moritz Mueller <m.mueller@salesforce.com>
mj-mueller
force-pushed
the
libraryChanges
branch
from
July 8, 2019 12:04
10d275f to
c76693c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only library that will be created is 'SiteGenesisSharedLibrary'. That library
consists of the default SiteGenesis library plus generated comdagen folders and
content assets. If the summary content asset is rendered then the home-main slot
will display it. Therefore slots.xml are rendered by its own template. Library tests
are adjusted.