feat(docs): update - #17
Conversation
…ick start guide with detailed steps for Docker Compose, clarify staff user provisioning, and add new seed data structure for improved setup experience
PR Summary by QodoFix clean frontend builds and expand Docker onboarding
AI Description
Diagram
High-Level Assessment
Files changed (11)
|
Code Review by Qodo
1. Gateway port breaks admin API
|
|
|
||
| Stop the stack with `docker compose -f deployment/docker-compose.yml down`. Add `-v` only if you intend to wipe Postgres and MinIO volumes. | ||
|
|
||
| Gateway (default `http://localhost:8080`, `GATEWAY_PORT` in `.env`): |
There was a problem hiding this comment.
1. Gateway port breaks admin api 🐞 Bug ≡ Correctness
Changing the documented GATEWAY_PORT only changes the host port, while the Administration FE image compiles its API origin as http://localhost:8080. Opening /admin on the configured port therefore still sends authentication and API requests to port 8080, where the gateway may not be listening.
Agent Prompt
## Issue description
The documentation advertises `GATEWAY_PORT` customization, but the Administration FE image hardcodes port 8080 into its compiled API origin. Make the configured public origin available during the image build or document and enforce the required matching configuration.
## Issue Context
Astro embeds `PUBLIC_ORIGIN` at build time. A runtime Compose environment value cannot modify the already-built static bundle.
## Fix Focus Areas
- README.md[98-104]
- deployment/docker-compose.yml[61-74]
- apps/Administration-FE/Dockerfile[1-9]
- deployment/.env.example[3-5]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
|
||
| Example emails above are documentation only — use any addresses you control. Pytest uses different editor email/password fixtures; those are not created by Compose. | ||
|
|
||
| 4. Sign in at `http://localhost:8080/admin`. Later staff: `flycatch-provision-admin --email someone@example.com --role editor` (`--role` is required: `administrator` or `editor`). |
There was a problem hiding this comment.
2. Provision command misses container 🐞 Bug ≡ Correctness
The Docker Compose quick start tells users to run flycatch-provision-admin directly on the host, although this workflow installs the executable only inside the backend image. Users following these instructions receive a command-not-found error unless they separately install the backend package.
Agent Prompt
## Issue description
The Docker Compose quick start presents the later-staff provisioning executable as a host command, but the setup does not install the Backend package on the host. Prefix it with the same Compose `exec backend` command used for the other Backend CLIs.
## Issue Context
The onboarding document already demonstrates the container-qualified form, and the executable is installed by the Backend image from its Python package entry point.
## Fix Focus Areas
- README.md[88-88]
- docs/onboarding.md[27-27]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| Compose does not provision staff. After services are healthy: | ||
|
|
||
| ```bash | ||
| docker compose exec backend alembic upgrade head | ||
| docker compose exec backend flycatch-seed-records |
There was a problem hiding this comment.
3. Compose already applies migrations 🐞 Bug ☼ Reliability
The new instructions claim Compose does not apply migrations and direct users to execute Alembic after startup, but the backend container already runs alembic upgrade head as its startup command. On first boot, executing the documented command while the container startup migration is still running can launch two migrations against the same database and fail on conflicting schema changes.
Agent Prompt
## Issue description
Compose currently applies migrations automatically through the backend image command, while the documentation says it does not and instructs users to run Alembic again. Choose one migration owner and make all startup documentation consistent with it, avoiding concurrent first-boot migrations.
## Issue Context
The Compose backend service does not override the Dockerfile command, so `alembic upgrade head` starts automatically before Uvicorn.
## Fix Focus Areas
- deployment/README.md[28-36]
- README.md[55-76]
- docs/onboarding.md[5-10]
- apps/Backend/Dockerfile[11-18]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Changes
Reviewer
@athulrajtflycatchtech