Skip to content

fix(share_plus): correct Windows share sheet data package setup #3975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MobileWeblink wants to merge 2 commits into
base: main
Choose a base branch
from
+321 −163
Open

fix(share_plus): correct Windows share sheet data package setup #3975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c2937a
fix(share_plus): correct Windows share sheet data package setup
Sep 17, 2026
106bbec
chore(share_plus): apply dart format to share_plus_windows_test.dart
Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 21 additions & 33 deletions packages/share_plus/share_plus/test/share_plus_windows_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,46 +19,34 @@ void main() {

// These tests are only valid on Windows versions lower than 10.0.17763.0.

test(
'url encoding is correct for &',
() async {
final mock = MockUrlLauncherPlatform();
test('url encoding is correct for &', () async {
final mock = MockUrlLauncherPlatform();

await SharePlusWindowsPlugin(
mock,
).share(ShareParams(text: 'foo&bar', subject: 'bar&foo'));
await SharePlusWindowsPlugin(
mock,
).share(ShareParams(text: 'foo&bar', subject: 'bar&foo'));

expect(mock.url, 'mailto:?subject=bar%26foo&body=foo%26bar');
},
skip: VersionHelper.instance.isWindows10RS5OrGreater,
);
expect(mock.url, 'mailto:?subject=bar%26foo&body=foo%26bar');
}, skip: VersionHelper.instance.isWindows10RS5OrGreater);

// see https://github.com/dart-lang/sdk/issues/43838#issuecomment-823551891
test(
'url encoding is correct for spaces',
() async {
final mock = MockUrlLauncherPlatform();
test('url encoding is correct for spaces', () async {
final mock = MockUrlLauncherPlatform();

await SharePlusWindowsPlugin(
mock,
).share(ShareParams(text: 'foo bar', subject: 'bar foo'));
await SharePlusWindowsPlugin(
mock,
).share(ShareParams(text: 'foo bar', subject: 'bar foo'));

expect(mock.url, 'mailto:?subject=bar%20foo&body=foo%20bar');
},
skip: VersionHelper.instance.isWindows10RS5OrGreater,
);
expect(mock.url, 'mailto:?subject=bar%20foo&body=foo%20bar');
}, skip: VersionHelper.instance.isWindows10RS5OrGreater);

test(
'can share URI on Windows',
() async {
final mock = MockUrlLauncherPlatform();
test('can share URI on Windows', () async {
final mock = MockUrlLauncherPlatform();

await SharePlusWindowsPlugin(
mock,
).share(ShareParams(uri: Uri.parse('http://example.com')));
await SharePlusWindowsPlugin(
mock,
).share(ShareParams(uri: Uri.parse('http://example.com')));

expect(mock.url, 'mailto:?body=http%3A%2F%2Fexample.com');
},
skip: VersionHelper.instance.isWindows10RS5OrGreater,
);
expect(mock.url, 'mailto:?body=http%3A%2F%2Fexample.com');
}, skip: VersionHelper.instance.isWindows10RS5OrGreater);
}
Loading
Loading