Repository navigation
fix: keep the desktop bar's right-hand controls pinned right - #973
Merged
diegotori merged 1 commit intoOct 20, 2026
Merged
Conversation
The position label was a loose Flexible next to a Spacer; the two split the free space and the label's unused share sat after the controls.
Ortes
force-pushed
the
fix/desktop-bar-right-controls
branch
from
October 13, 2026 19:24
e2bd630 to
178e9df
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #973 +/- ##
=======================================
Coverage 82.60% 82.61%
=======================================
Files 48 48
Lines 2967 2968 +1
=======================================
+ Hits 2451 2452 +1
Misses 516 516 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Ortes
added a commit
to Ortes/cineseed
that referenced
this pull request
Oct 19, 2026
diegotori
added a commit
that referenced
this pull request
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaterialDesktopControlsputs its right-hand controls (fullscreen, options, subtitles, cast, additional controls) partway across the bar instead of at the right edge.Cause: a3c8955 made the position label a loose
Flexiblenext to the existingSpacer. Both have flex 1, so they split the free space evenly. The label only uses its natural width, so the rest of its share ends up after the controls. At 1280 px wide, the fullscreen button sits 375 px from the right edge.Fix: make the label the bar's only flex child (
Expanded+Alignto the start) and drop theSpacer.This keeps what the
Flexiblewas added for: on a narrow window the label still shrinks instead of overflowing when there are extra controls. I checked 360, 420 and 480 px with threeadditionalControls. There's no overflow on either version, and the fullscreen button reaches the right edge on both. The label also gets all of the leftover width instead of half of it (17 px instead of 9 px at 360 px).Added
test/desktop_bar_layout_test.dart. It fails onmaster(375 px from the edge) and passes with the fix.Both are from the example app on Chrome with "Desktop controls" selected. The "after" shot was taken while the controls were fading out.