Skip to content

Run CI for branch pushes and pull requests - #133

Merged
nohli merged 4 commits into
update-flutter-3-44-agp9from
ci/run-checks-on-pull-requests
Sep 25, 2026
Merged

nohli merged 4 commits into
update-flutter-3-44-agp9from
ci/run-checks-on-pull-requests

Conversation

@nohli

@nohli nohli commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

This runs the existing package, example, pub-score, and publish-dry-run checks for every branch push and pull request, so branch heads are validated before they are merged.

Push and pull-request runs remain separate on purpose: one validates the branch head, while the other validates GitHub's merge ref.

The Android integration matrix still covers APIs 24, 30, and 35. It skips documentation, tooling, and unit-test-only changes while continuing to run for shared Dart code, native Android code, dependencies, example runtime code, integration tests, and its own workflow.

Standard Flutter jobs allow 20 minutes for setup and cache restoration, while the analyzer, tests, and builds remain individually capped at 10 minutes.

Validated locally with Flutter 3.47.5:

  • Package and example analysis passed.
  • All package and example tests passed.
  • The real Android integration suite passed 3/3 tests on API 37.
  • The workflow YAML and shell steps were validated.

This is stacked on #126 and should be merged after it.

Copilot AI lite review requested due to automatic review settings September 25, 2026 05:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Avoid duplicate Android matrix runs for commits pushed to branches with open pull requests.

Review effort: Lite
Findings: None

What changed in this PR

Updates CI to validate branch pushes and pull requests across package, example, publishing, and Android integration workflows.

Changes:

  • Expands CI triggers to branches and pull requests.
  • Adds Android integration path filtering.
  • Preserves API 24, 30, and 35 coverage.
File Summary
.github/​workflows/​pub_score.yml Runs pub-score checks on all branches.
.github/​workflows/​pub_publish_dry_run.yml Runs publish dry runs for branches and pull requests.
.github/​workflows/​integration_tests_android.yml Adds filtered branch and pull-request triggers.
.github/​workflows/​flutter_checks.yml Runs Flutter checks on all branches.
.github/​workflows/​flutter_build_example.yml Builds the example on all branches.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues were identified.

Review effort: Lite
Findings: None

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The concurrency keys can cancel required checks and do not properly replace successive branch runs.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 5 Medium severity

Open (5)

Comment thread .github/workflows/flutter_build_example.yml Outdated
Comment thread .github/workflows/flutter_checks.yml Outdated
Comment thread .github/workflows/integration_tests_android.yml Outdated
Comment thread .github/workflows/pub_publish_dry_run.yml Outdated
Comment thread .github/workflows/pub_score.yml Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Fork pull requests currently bypass the promised CI validation.

Review effort: Lite
Findings: None

Resolved since last review (5)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review comments remain.

Review effort: Lite
Findings: None

@nohli
nohli force-pushed the ci/run-checks-on-pull-requests branch from bda3851 to aedc4ab Compare September 25, 2026 06:09
@nohli
nohli requested a lite review from Copilot September 25, 2026 06:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues were identified.

Review effort: Lite
Findings: None

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Address duplicate push/PR runs and restore equivalent Android concurrency control.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity

Open (1)

Comment thread .github/workflows/integration_tests_android.yml

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues remain.

Review effort: Lite
Findings: None

Resolved since last review (1)

@nohli
nohli force-pushed the ci/run-checks-on-pull-requests branch from 9345d94 to 7766da5 Compare September 25, 2026 07:43
@nohli
nohli requested a lite review from Copilot September 25, 2026 07:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues were identified.

Review effort: Lite
Findings: None

@nohli
nohli merged commit 63e3f11 into update-flutter-3-44-agp9 Sep 25, 2026
23 checks passed
@nohli
nohli deleted the ci/run-checks-on-pull-requests branch September 25, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants