Skip to content

Use the configured Dart formatter width - #132

Merged
nohli merged 1 commit into
update-flutter-3-44-agp9from
ci/use-configured-format-width
Sep 25, 2026
Merged

nohli merged 1 commit into
update-flutter-3-44-agp9from
ci/use-configured-format-width

Conversation

@nohli

@nohli nohli commented Sep 25, 2026

Copy link
Copy Markdown
Member

The Flutter 3.47 migration already defines the 120-column formatter width in analysis_options.yaml, so the CI command does not need to repeat it.

This removes only the redundant command-line override. It is stacked on #126 and keeps formatting behavior unchanged.

Dart documentation: https://dart.dev/tools/dart-format#configure-the-formatter

Validation:

  • Dart reads the configured width directly
  • the config-only command formats 5 files with 0 changes
  • the workflow YAML parses successfully

Copilot AI lite review requested due to automatic review settings September 25, 2026 00:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues remain.

Review effort: Lite
Findings: None

What changed in this PR

Removes the redundant Dart formatter width override so CI uses the configured 120-column width.

Changes:

  • Simplifies the formatting check command.
  • Preserves repository-configured formatter behavior.
File Description
.github/​workflows/​flutter_checks.yml Uses the configured formatter settings in CI.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@nohli
nohli merged commit 4c3dfe5 into update-flutter-3-44-agp9 Sep 25, 2026
11 checks passed
@nohli
nohli deleted the ci/use-configured-format-width branch September 25, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants