Skip to content

Fix shimmer loading cookbook image paths - #13933

Open
rahulshahDEV wants to merge 1 commit into
flutter:mainfrom
rahulshahDEV:fix/shimmer-cookbook-image-paths-13926
Open

rahulshahDEV wants to merge 1 commit into
flutter:mainfrom
rahulshahDEV:fix/shimmer-cookbook-image-paths-13926

Conversation

@rahulshahDEV

@rahulshahDEV rahulshahDEV commented Sep 26, 2026 •

Copy link
Copy Markdown

Fixes #13926.

The shimmer loading cookbook and its example used image URLs that omitted the effects directory. Update the Markdown sample and all three example variants to point to the tracked image assets.

Validation: confirmed all 10 image references resolve to files in the repository, Dart formatting passed, and git diff whitespace checks passed. I did not run the full website build.

@rahulshahDEV
rahulshahDEV requested review from a team and sfshaza2 as code owners September 26, 2026 07:29
@google-cla

google-cla Bot commented Sep 26, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the asset URLs for the shimmer loading cookbook example by adding /effects/ to the path of the avatar and food images across several Dart files and the Markdown documentation. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash at shimmer-loading cookbook full sample code

1 participant