Skip to content

Decoupling Material and Cupertino from the core framework - #13930

Open
sfshaza2 wants to merge 2 commits into
mainfrom
decouping
Open

sfshaza2 wants to merge 2 commits into
mainfrom
decouping

Conversation

@sfshaza2

Copy link
Copy Markdown
Contributor

This is the first PR. The DartPad instances still use flutter/cupertino and flutter/material because DartPad can't handle the external packages yet.

@sfshaza2
sfshaza2 requested a review from a team as a code owner September 25, 2026 20:18
@parlough
parlough self-requested a review September 25, 2026 20:19

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates package imports across numerous example files, replacing 'package:flutter/material.dart' and 'package:flutter/cupertino.dart' with 'package:material_ui/material.dart' and 'package:cupertino_ui/cupertino.dart' respectively. The review feedback correctly identifies a few files that inconsistently import 'package:cupertino_dart/cupertino.dart' instead of 'package:cupertino_ui/cupertino.dart', which could lead to compilation errors.

import 'dart:collection';

import 'package:flutter/cupertino.dart';
import 'package:cupertino_dart/cupertino.dart';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Inconsistent package import. This file imports package:cupertino_dart/cupertino.dart, whereas other files in this pull request use package:cupertino_ui/cupertino.dart. This inconsistency will likely lead to compilation or import errors if cupertino_dart is not a valid or intended package name.

Suggested change
import 'package:cupertino_dart/cupertino.dart';
import 'package:cupertino_ui/cupertino.dart';
References
  1. Report an issue only if the change introduces or worsens it, it's of medium severity or higher, and you can state its concrete consequence (e.g., incorrect API names or expected results). (link)

import 'dart:collection';

import 'package:flutter/cupertino.dart';
import 'package:cupertino_dart/cupertino.dart';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Inconsistent package import. This file imports package:cupertino_dart/cupertino.dart, whereas other files in this pull request use package:cupertino_ui/cupertino.dart. This inconsistency will likely lead to compilation or import errors if cupertino_dart is not a valid or intended package name.

Suggested change
import 'package:cupertino_dart/cupertino.dart';
import 'package:cupertino_ui/cupertino.dart';
References
  1. Report an issue only if the change introduces or worsens it, it's of medium severity or higher, and you can state its concrete consequence (e.g., incorrect API names or expected results). (link)

import 'dart:collection';

import 'package:flutter/cupertino.dart';
import 'package:cupertino_dart/cupertino.dart';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Inconsistent package import. This file imports package:cupertino_dart/cupertino.dart, whereas other files in this pull request use package:cupertino_ui/cupertino.dart. This inconsistency will likely lead to compilation or import errors if cupertino_dart is not a valid or intended package name.

Suggested change
import 'package:cupertino_dart/cupertino.dart';
import 'package:cupertino_ui/cupertino.dart';
References
  1. Report an issue only if the change introduces or worsens it, it's of medium severity or higher, and you can state its concrete consequence (e.g., incorrect API names or expected results). (link)

import 'dart:collection';

import 'package:flutter/cupertino.dart';
import 'package:cupertino_dart/cupertino.dart';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Inconsistent package import. This file imports package:cupertino_dart/cupertino.dart, whereas other files in this pull request use package:cupertino_ui/cupertino.dart. This inconsistency will likely lead to compilation or import errors if cupertino_dart is not a valid or intended package name.

Suggested change
import 'package:cupertino_dart/cupertino.dart';
import 'package:cupertino_ui/cupertino.dart';
References
  1. Report an issue only if the change introduces or worsens it, it's of medium severity or higher, and you can state its concrete consequence (e.g., incorrect API names or expected results). (link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant