Skip to content

[camera_android_camerax] Move misplaced Javadoc above annotations - #13040

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
jesswrd:pack-camerax-jdk-25
Sep 29, 2026
Merged

auto-submit[bot] merged 3 commits into
flutter:mainfrom
jesswrd:pack-camerax-jdk-25

Conversation

@jesswrd

@jesswrd jesswrd commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Moved comments above the annotations to fix dangling-doc-comments compiler warning. This is part of the work to ensure packages works on JDK 25.

JDK 25's compiler added a dangling-doc-comments is a javac lint check that was new in JDK 23 (JDK-8303689) that warns when a Javadoc comment isnt attached to class, method, or field.

Partially Addresses flutter/flutter#193404

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

The Javadoc for DeviceOrientationManager.createOrientationEventListener was
placed after its annotations, so it was not attached to the method. javac 23+
reports this with the new dangling-doc-comments lint, which breaks the example
app's -Xlint:all -Werror build on JDK 25.
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 27, 2026
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the camera_android_camerax package to version 0.7.5+1 and resolves a build failure on JDK 23+ by moving the @VisibleForTesting and @NonNull annotations below the Javadoc comment for createOrientationEventListener in DeviceOrientationManager.java. There are no review comments, and I have no feedback to provide.

@camsim99 camsim99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the changelog/pubspec update! otherwise lgtm

@jesswrd jesswrd added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Sep 29, 2026
@jesswrd
jesswrd requested a review from camsim99 September 29, 2026 17:11
@jesswrd jesswrd added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 29, 2026
@auto-submit
auto-submit Bot merged commit b0abd88 into flutter:main Sep 29, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: camera platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants