Skip to content

[material_ui] Add splashRadius property to BottomNavigationBar and BottomNavigationBarThemeData - #12694

Closed
Mairramer wants to merge 4 commits into
flutter:mainfrom
Mairramer:add-splash-radius-to-bottomnavigationbar
Closed

Mairramer wants to merge 4 commits into
flutter:mainfrom
Mairramer:add-splash-radius-to-bottomnavigationbar

Conversation

@Mairramer

Copy link
Copy Markdown
Contributor

as title
Closes flutter/flutter#117957

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Aug 30, 2026
@Mairramer
Mairramer force-pushed the add-splash-radius-to-bottomnavigationbar branch from 96499cb to d83d80a Compare August 30, 2026 20:18
@Mairramer Mairramer changed the title Add splashRadius property to BottomNavigationBar and BottomNavigationBarThemeData [material_ui] Add splashRadius property to BottomNavigationBar and BottomNavigationBarThemeData Aug 31, 2026
@Mairramer

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a splashRadius property to BottomNavigationBar and BottomNavigationBarThemeData to allow customization of the ink splash radius for bottom navigation bar items, along with associated tests and changelog updates. The review feedback suggests updating the assertion for splashRadius to use the double literal 0.0 instead of the integer 0 to maintain consistency with other assertions in the constructor.

Comment thread packages/material_ui/lib/src/bottom_navigation_bar.dart Outdated
@Mairramer Mairramer added the CICD Run CI/CD label Sep 27, 2026
@Mairramer
Mairramer marked this pull request as ready for review September 27, 2026 12:04

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a splashRadius property to BottomNavigationBar and BottomNavigationBarThemeData, allowing customization of the ink splash radius for item tap effects. It also adds comprehensive unit tests to verify default values, custom configurations, assertions, and theme overrides. No review comments were provided, so there is no additional feedback.

@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Sep 27, 2026
@Mairramer Mairramer added the CICD Run CI/CD label Sep 27, 2026
@QuncCccccc

Copy link
Copy Markdown
Contributor

BottomNavigationBar is a bit old and should be replaced by NavigationBar in M3. In Material Design 3 and expressive, we don't support splash feature, so I'm closing this PR since this feature doesn't align with the latest design specs.

@QuncCccccc QuncCccccc closed this Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure Splash Radius of Icon in BottomNavigationBar

2 participants