Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the IntelliJ plugin verification process by introducing a centralized bash script, tool/check_verifier_baselines.sh, to normalize and compare verifier reports against committed baselines. It updates the baseline files for IDE branches 252, 253, and 261 to a new tab-separated format, simplifies the CI workflow in tool/github.sh, and adds detailed documentation to CONTRIBUTING.md. The review feedback recommends dynamically discovering baseline versions in tool/github.sh to prevent version drift and guarding the mktemp call in the new script to handle failures robustly.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Collaborator
Author
|
@helin24: this one is ready for review 🦅 |
helin24
approved these changes
Sep 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports flutter/dart-intellij-third-party#670. Improves visibility of new failures and ensures all verifications run (even after a failure).
LLM summary:
VERIFY_BOTruns four verifications and then diffs the reports against committed baselines. Two things went wrong whenever something actually broke:set -e, so the first failing verification aborted the script. The baseline diff — the step that explains which issues are new — was skipped precisely when it was needed.Changes
tool/check_verifier_baselines.sh: one script shared by CI (check) and local re-baselining (update), so the two cannot drift.VERIFY_BOTrecords each verification's status instead of aborting, and always runs the baseline diff.tool/update_baselines.shdelegates to the same script.CONTRIBUTING.md.Baseline format
Baselines gain a provenance header and a section tag:
The section keeps the kind of finding visible in the diff. The issue text itself is unchanged: regenerating produces exactly the same set of issues as the committed baselines, only reformatted.
Notes
verifyPlugin's exit status stays ignored (|| true).failureLeveljudges severity with no notion of what we have already accepted, so a baselined issue in an enabled category would fail every run with no way to suppress it. Novelty remains the baseline check's job, and a problem serious enough to matter still lands in the report, so it is still caught if it is new.DartTemplateContextType.<init>(local builds emit names, CI does not) now applies only when comparing, never when writing, so the committed file stays a faithful record of the report.Review the contribution guidelines below:
AUTHORSfile.CHANGELOG.mdif appropriate.Contribution guidelines:
our contributor guide and
the Flutter organization contributor guide
for general expectations for PRs.
dart format.practices (discussion).