Skip to content

fix: Make federated_plugin demo working on windows - #153

Merged
parlough merged 6 commits into
flutter:mainfrom
Gustl22:federated_plugin_windows
Sep 25, 2026
Merged

fix: Make federated_plugin demo working on windows#153
parlough merged 6 commits into
flutter:mainfrom
Gustl22:federated_plugin_windows

Conversation

@Gustl22

@Gustl22 Gustl22 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Fixes compilation error on windows and updates the windows build folder (Flutter v3.44.0)
Needs #152 first.

Pre-launch Checklist

  • I signed the CLA.

@Gustl22
Gustl22 force-pushed the federated_plugin_windows branch from 466c0b5 to cf4fa4f Compare August 25, 2026 17:27
@Gustl22
Gustl22 marked this pull request as ready for review August 25, 2026 17:28
@Gustl22

Gustl22 commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@ericwindmill thank you for reviewing / merging #152. Appreciate, if you could afford the time to review this PR also.

Edit: Also I saw this issue: flutter/samples#2520
Do you know why federated_plugin was moved from https://github.com/flutter/samples to this repo?
The majority of native packages in https://github.com/flutter/packages still use this design. Especially for the desktop platforms, it would be good to have a reference, as there are no examples at all for e.g. Event channels on Windows / Linux.

@Gustl22

Gustl22 commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

@ericwindmill can I interest you in reviewing / merging this PR? Thank you for the help!

parlough
parlough approved these changes Sep 25, 2026
View reviewed changes

@parlough parlough left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Gustl22! Some small suggestions to consider before landing:

Comment thread federated_plugin/federated_plugin/example/windows/CMakeLists.txt Outdated
Comment thread federated_plugin/federated_plugin/example/windows/runner/main.cpp Outdated
Comment thread federated_plugin/federated_plugin_windows/windows/federated_plugin_windows_plugin.cpp Outdated
Gustl22 and others added 3 commits September 25, 2026 09:41
@Gustl22

Gustl22 commented Sep 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@parlough thanks for the proposals! Ready for another review now :)

parlough
parlough approved these changes Sep 25, 2026
View reviewed changes

@parlough parlough left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those updates! Still looks good to me :)

@parlough
parlough merged commit a8e160d into flutter:main Sep 25, 2026
6 checks passed
@Gustl22
Gustl22 deleted the federated_plugin_windows branch September 25, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parlough parlough parlough approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Gustl22 @parlough