Skip to content

191737 reset presubmit check - #5157

Merged
auto-submit[bot] merged 7 commits into
flutter:mainfrom
ievdokdm:191737-reset-presubmit-check
Sep 25, 2026
Merged

auto-submit[bot] merged 7 commits into
flutter:mainfrom
ievdokdm:191737-reset-presubmit-check

Conversation

@ievdokdm

@ievdokdm ievdokdm commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Changed presubmit flow to immediately notify if any presubmit job failed and switch check-run back in progress if re-run all failed:

  • Keep Dashboard Checks check-run always in progress unless presubmit successed
  • Added Presubmit check-run
  • Fail Presubmit check-run immediately once presubmit job failed
  • Create new Presubmit check run if all jobs re-run

fix: flutter/flutter#191737

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 25, 2026
@ievdokdm
ievdokdm requested review from eyebrowsoffire and jtmcdole and removed request for eyebrowsoffire September 25, 2026 21:05

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new 'Presubmit' check run flow that allows resetting failed check runs to in-progress when failed jobs are retried, along with refactoring several check-run handling methods and adding author tracking to presubmit jobs. The review feedback highlights several critical issues: a missing dart:io import in github_checks_util.dart causing a compilation error, potential null pointer exceptions in scheduler.dart due to unsafe null assertions on pullRequest and guard.checkSuiteId, an omitted GitHubCheckRunIdBuildTag in luci_build_service.dart for merge queues, and a grammatically incorrect getter name isSuccessed in presubmit_guard_conclusion.dart.

Comment thread app_dart/lib/src/foundation/github_checks_util.dart
Comment thread app_dart/lib/src/service/scheduler.dart
Comment thread app_dart/lib/src/service/luci_build_service.dart Outdated
Comment thread app_dart/lib/src/service/scheduler.dart
Comment thread app_dart/lib/src/model/common/presubmit_guard_conclusion.dart Outdated
@ievdokdm
ievdokdm force-pushed the 191737-reset-presubmit-check branch from 949cf43 to 038728c Compare September 25, 2026 21:54

@eyebrowsoffire eyebrowsoffire left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I think in the longer-term, we should try to decouple the presubmit guard from the single GitHub checkrun ID and try to consolidate these checkruns so that we don't have three separate ones, but this works for now.

@ievdokdm ievdokdm added the autosubmit Merge PR when tree becomes green via auto submit App. label Sep 25, 2026
@auto-submit
auto-submit Bot merged commit 351ada0 into flutter:main Sep 25, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App. CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reset Dashboard Checks check-run to In Progress when re-run all failed job

2 participants