190580 Show filter dialog by pressing ctrl+f or / - #5156
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces keyboard shortcuts (such as '/' and 'Ctrl+F') to open the filter dialog in the presubmit view, ensuring the regex input field is automatically focused upon opening. It also updates the error dialog to support text selection and adds corresponding widget tests. Regarding the feedback, the reviewer noted that the manual focus request inside 'addPostFrameCallback' in 'FilterDialog' is redundant because the 'TextField' already has its 'autofocus' property set, which can be safely removed to simplify the code.
jtmcdole
reviewed
Sep 23, 2026
| /// A dialog that allows users to filter jobs in the Presubmit Dashboard. | ||
| class FilterDialog extends StatefulWidget { | ||
| const FilterDialog({super.key}); | ||
| const FilterDialog({super.key, this.autofocusRegex = false}); |
Member
There was a problem hiding this comment.
Why not always auto-focus the text box?
jtmcdole
approved these changes
Sep 23, 2026
jtmcdole
left a comment
jtmcdole
left a comment
Member
There was a problem hiding this comment.
welcome to the wonderful world of focusNodes.
ievdokdm
added
the
autosubmit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: flutter/flutter#190580