Skip to content

Added resetFailedCheckRun flag - #5148

Merged
auto-submit[bot] merged 4 commits into
flutter:mainfrom
ievdokdm:191737-checkSuiteFlow-flag
Sep 22, 2026
Merged

auto-submit[bot] merged 4 commits into
flutter:mainfrom
ievdokdm:191737-checkSuiteFlow-flag

Conversation

@ievdokdm

@ievdokdm ievdokdm commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Added resetFailedCheckRun flag.
Deleted unifiedCheckRunFlow flag as no longer needed.
in scope of flutter/flutter#191737

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 14, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the unifiedCheckRunFlow configuration with a new checkSuiteFlow configuration across the application, including configuration files, dynamic config logic, and generated files. The feedback suggests two improvements: first, making the GitHub username comparison case-insensitive in isCheckSuiteFlowEnabledForUser to prevent mismatch issues; second, ensuring that the useForUsers list in the immutable CheckSuiteFlow class is unmodifiable to preserve immutability guarantees.

Comment thread app_dart/lib/src/service/flags/dynamic_config.dart Outdated
Comment thread app_dart/lib/src/service/flags/check_suite_flow.dart Outdated
ievdokdm and others added 3 commits September 22, 2026 08:59
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ievdokdm
ievdokdm force-pushed the 191737-checkSuiteFlow-flag branch from a6012b2 to c5a8b30 Compare September 22, 2026 16:00
@ievdokdm ievdokdm changed the title Added checkSuiteFlow flag Added resetFailedCheckRun flag Sep 22, 2026
@ievdokdm ievdokdm added the autosubmit Merge PR when tree becomes green via auto submit App. label Sep 22, 2026
@auto-submit
auto-submit Bot merged commit 33b49d3 into flutter:main Sep 22, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App. CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants