Skip to content

Add environment variable for plugin names to the mcp configuration - #238

Merged
keertip merged 4 commits into
flutter:mainfrom
keertip:env-var
Sep 17, 2026
Merged

keertip merged 4 commits into
flutter:mainfrom
keertip:env-var

Conversation

@keertip

@keertip keertip commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

This PR

  • moves the mcp configuration to the plugin.json file for the respective agents
  • adds an environment variable to indicate the agent plugin calling the mcp server
  • remove the unused .mcp.json file
  • bumps the version numbers for the plugins

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the plugin configuration files (.claude-plugin/plugin.json, .codex-plugin/plugin.json, and .cursor-plugin/plugin.json) to bump their versions to 1.0.5 and inline the mcpServers configuration with specific AGENT_PLUGIN environment variables (claude-code, codex, and cursor respectively), while removing the external .mcp.json file. The feedback suggests adding a trailing newline to the end of each of these JSON files to ensure POSIX compatibility and prevent git diff warnings.

Comment thread .claude-plugin/plugin.json Outdated
Comment thread .codex-plugin/plugin.json Outdated
Comment thread .cursor-plugin/plugin.json Outdated
keertip and others added 3 commits September 17, 2026 09:25
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@keertip
keertip merged commit e89522a into flutter:main Sep 17, 2026
7 checks passed
@keertip
keertip deleted the env-var branch September 17, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants