Skip to content

This PR is to add comments to mockAlluxioEngineForTests in fluid/pkg/ddc/alluxio/mock_utils.go. #6018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mini-star720 wants to merge 3 commits into
base: master
Choose a base branch
from
+5 −0
Open

This PR is to add comments to mockAlluxioEngineForTests in fluid/pkg/ddc/alluxio/mock_utils.go. #6018

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb77729
Add Notation to mockAlluxioEngineForTests in mockAlluxioEngineForTests
mini-star720 Jun 17, 2026
9eb6eea
Revert "Add Notation to mockAlluxioEngineForTests in mockAlluxioEngin…
mini-star720 Jun 17, 2026
33ee918
Add Notation to mockAlluxioEngineForTests in fluid/pkg/ddc/alluxio/mo…
mini-star720 Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/ddc/alluxio/mock_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,11 @@ func mockFluidObjectsForTests(namespacedName types.NamespacedName) (*datav1alpha
return dataset, runtime
}

// mockAlluxioEngineForTests builds a minimal AlluxioEngine instance for unit tests.
// It validates that the given dataset and runtime are a matching pair (same namespace/name,
// and runtime is owned by the dataset) and panics otherwise.
// The returned engine has a basic runtime info, a fake logger and a fake event recorder.
// Client and Helper are intentionally left nil so that test cases can inject them when needed.
func mockAlluxioEngineForTests(dataset *datav1alpha1.Dataset, runtime *datav1alpha1.AlluxioRuntime) *AlluxioEngine {
if dataset.Namespace != runtime.Namespace ||
dataset.Name != runtime.Name ||
Expand Down
Loading