Repository navigation
in_tcp: do not put the whole received data into logs - #5592
Merged
Merged
Conversation
Before: when a message does not match the parser, the whole message is written into one warn log, so a 32MiB message makes a 32MiB log line. After: when a message longer than 16KiB does not match the parser, only the first 16KiB and the size are logged. 16KiB is larger than normal log lines, such as lines split by Docker or Kubernetes, so the warn log does not change for them. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Watson1978
added
the
backport to v1.19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
Before: when a message does not match the parser, the whole message is written into one warn log, so a 32MiB message makes a 32MiB log line.
After: when a message longer than 16KiB does not match the parser, only the first 16KiB and the size are logged.
16KiB is larger than normal log lines, such as lines split by Docker or Kubernetes, so the warn log does not change for them.
Docs Changes:
N/A
Release Note:
in_tcp: do not put the whole received data into logs