Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions lib/fluent/plugin/parser_syslog.rb
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,21 @@ def parse_rfc5424(text, &block)
else
start = cursor
i = text.index('] '.freeze, cursor)
if i && text[i - 1] == '\\'.freeze # skip escaped ']' (RFC 5424 6.3.3)
offset = i
previous = '\\'.freeze
candidate = false
i = nil
text.slice(offset, text.length).each_char do |char|
if candidate && char == SPLIT_CHAR
i = offset - 1
break
end
candidate = char == ']'.freeze && previous != '\\'.freeze
previous = char
offset += 1
end
end
extradata = if i
diff = i + 1 - start # calculate ']' position
cursor += diff
Expand Down
34 changes: 34 additions & 0 deletions test/plugin/test_parser_syslog.rb
Original file line number Diff line number Diff line change
Expand Up @@ -762,6 +762,40 @@ def test_parse_with_rfc5424_message_includes_right_bracket(param)
end
end

data(
'regexp/with message' => ['regexp', '[x@1 a="b\] c"]', 'msg'],
'string/with message' => ['string', '[x@1 a="b\] c"]', 'msg'],
'regexp/without message' => ['regexp', '[x@1 a="b\] c"]', nil],
'string/without message' => ['string', '[x@1 a="b\] c"]', nil],
'regexp/multiple structured data' => ['regexp', '[x@1 a="b\] c"][y@1 d="e"]', 'msg'],
'string/multiple structured data' => ['string', '[x@1 a="b\] c"][y@1 d="e"]', 'msg'],
'regexp/escaped backslash at end of value' => ['regexp', '[x@1 a="b\\\\"]', 'msg'],
'string/escaped backslash at end of value' => ['string', '[x@1 a="b\\\\"]', 'msg'],
'regexp/escaped backslash before right bracket' => ['regexp', '[x@1 a="b\\\\] c"]', 'msg'],
'string/escaped backslash before right bracket' => ['string', '[x@1 a="b\\\\] c"]', 'msg'],
'string/invalid byte in message' => ['string', '[x@1 a="b\] c"]', "m\xFFsg"],
)
def test_parse_with_rfc5424_structured_data_includes_escaped_right_bracket(data)
parser_engine, extradata, message = data
@parser.configure(
'message_format' => 'rfc5424',
'with_priority' => true,
'parser_engine' => parser_engine
)
text = "<14>1 2026-04-25T16:43:29.123Z host app 123 ID #{extradata}"
text += " #{message}" if message

result = nil
@parser.instance.parse(text) do |time, record|
result = [time, record]
end
# string parser removes backslashes from extradata
extradata = extradata.delete('\\') if parser_engine == 'string'
expected = {'host' => 'host', 'ident' => 'app', 'pid' => '123', 'msgid' => 'ID', 'pri' => 14, 'extradata' => extradata}
expected['message'] = message if message
assert_equal([event_time('2026-04-25T16:43:29.123Z', format: '%Y-%m-%dT%H:%M:%S.%L%z'), expected], result)
end

data('regexp' => 'regexp', 'string' => 'string')
def test_parse_with_rfc5424_empty_message(param)
@parser.configure(
Expand Down
Loading