Repository navigation
gem: remove yajl-ruby from runtime dependencies for Ruby 4.1 - #5574
Merged
Merged
Conversation
The Ruby version guard in the gemspec is evaluated only at gem build time, so the published gem always depends on yajl-ruby. yajl-ruby cannot be built on Ruby 4.1, so installing fluentd fails there. Fluentd itself no longer uses yajl-ruby. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
force-pushed
the
remove-yajl-ruby-dependency
branch
from
October 26, 2026 02:03
eb308e0 to
9cb7889
Compare
Watson1978
changed the title
Watson1978
marked this pull request as ready for review
October 26, 2026 02:39
kenhys
approved these changes
Oct 26, 2026
Contributor
Author
|
Thanks |
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
The yajl-ruby dependency in
fluentd.gemspecis guarded byRUBY_VERSION < "4.1", but the guard is evaluated only when the gem is built. So the published fluentd 1.20.0 gem always depends on yajl-ruby, andgem install fluentdfails on Ruby 4.1 because yajl-ruby cannot be built there. Fluentd itself no longer uses yajl-ruby since #5090 and #5383, so this PR removes the dependency.Docs Changes:
N/A
Release Note:
gem: remove yajl-ruby from runtime dependencies to fix installation on Ruby 4.1. Plugins that
require 'yajl'need to declare yajl-ruby in their own gemspec.🤖 Generated with Claude Code