refactor: filter method - #21
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the filter functionality by consolidating filter methods and adding a short -f option for filtering. The main purpose is to improve code maintainability and provide a more convenient CLI interface.
- Introduced a unified
createFilterfunction that handles both prefix and partial matching - Added
-fas a short alias for the--filteroption - Added comprehensive test coverage for the new
-foption functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/core/filter.ts | Refactored to use a unified createFilter function and deprecated old methods |
| src/constants/cli.ts | Added -f alias mapping for the filter option |
| src/cli/config.ts | Updated help text to show the new -f short option |
| tests/unit/cli/parser.test.ts | Added test cases for -f option parsing and validation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
flowernotfound
added a commit
that referenced
this pull request
Aug 31, 2025
flowernotfound
added a commit
that referenced
this pull request
Aug 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged filter functionality.
add -f option.