deps: bump quic-go to v0.63.0 - #109
Merged
Merged
Conversation
The v0.63.0 http3 breaking changes do not reach this module or webtransport-go v0.13.0. Extended CONNECT now leaves URL.Host and URL.Scheme empty, but only r.Host and r.URL.Path are read here, and both are still set. Stream errors now arrive as *http3.Error, but webtransport-go already handles both that and *quic.StreamError, and WebTransport data streams are plain QUIC streams. Verified with go test ./..., go test -race over session/relay/cmd, golangci-lint, and make interop-loopback (moqt:// and https://, 12/12). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
github.com/quic-go/quic-gofrom v0.62.0 to v0.63.0. Onlygo.mod/go.sumchange.Breaking changes in v0.63.0 — none reach this module
URL.Host/URL.Schemeempty (#5841).wtconnandrelaynetread onlyr.Hostandr.URL.Path, both still set. webtransport-go v0.13.0's origin check usesr.Hostas well.*http3.Error(#5852). webtransport-go already handles both*http3.Errorand*quic.StreamError. WebTransport data streams are plain QUIC streams, so thequicconn/wtconnerror checks are unaffected.Observable difference
On WebTransport session close, the relay's debug log now reads
H3_DATAGRAM_ERROR (local): H3_NO_ERRORinstead ofH3_DATAGRAM_ERROR (local): Application error 0x100 (remote). TheH3_DATAGRAM_ERRORwrapper was already there on v0.62.0; I confirmed this with an interop run on the old version. Only the wrapped error text changed, which matches the new*http3.Errortype, and it appears only in debug logging.Verification
go test ./...go test -raceoverpkg/moqt/session/...,pkg/relay/...,cmd/...golangci-lint run: 0 issuesmake interop-loopback: 12/12 (6 cases each overmoqt://andhttps://)/moqt-reviewwas not run: the diff contains no protocol code.🤖 Generated with Claude Code