Skip to content

Update types to Oct 1st 2026 - #818

Merged
celdrake merged 1 commit into
flightctl:mainfrom
celdrake:app-delta-update-size
Oct 1, 2026
Merged

celdrake merged 1 commit into
flightctl:mainfrom
celdrake:app-delta-update-size

Conversation

@celdrake

@celdrake celdrake commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Update to latest OpenAPI schema.

Most relevant change is the change of the size field for delta updates.

Made-with: Cursor

Summary

  • libs/types/ adds exports for device delta outcomes, device system-info statuses, label-sync mappings, and system-info source statuses.
  • libs/ui-components/ reads delta update sizes from appStatus.deltaSize and deviceStatus.os.deltaSize. The device fallback reason remains unchanged.
  • These changes affect shared UI components. They may affect both standalone and OCP plugin interfaces if they consume these components; that usage is not established by the supplied evidence.
  • No changes are reported in libs/i18n/, libs/cypress/, apps/standalone/, apps/ocp-plugin/, proxy/, packaging/, or .github/workflows/. The supplied changes do not indicate E2E test, Go auth proxy, container build, or CI configuration changes.
  • Test results and review finding counts are not available.

Risk classification

Risk label: unavailable. The supplied context does not include the labeling instructions or an applied risk label, so the applicable criteria cannot be verified. No evidence establishes that the change was close to another classification.

Made-with: Cursor
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: flightctl/flightctl-ui/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: d5103606-259f-477e-a2d6-347ccec7801e

📥 Commits

Reviewing files that changed from the base of the PR and between c953ed0 and 9b67039.

⛔ Files ignored due to path filters (22)
  • libs/types/models/ApplicationImageDigest.ts is excluded by !libs/types/models/**
  • libs/types/models/ConditionBase.ts is excluded by !libs/types/models/**
  • libs/types/models/ConditionType.ts is excluded by !libs/types/models/**
  • libs/types/models/DeviceApplicationStatus.ts is excluded by !libs/types/models/**
  • libs/types/models/DeviceDeltaApplyOutcomeType.ts is excluded by !libs/types/models/**
  • libs/types/models/DeviceDeltaApplyStatus.ts is excluded by !libs/types/models/**
  • libs/types/models/DeviceOsSpec.ts is excluded by !libs/types/models/**
  • libs/types/models/DeviceOsStatus.ts is excluded by !libs/types/models/**
  • libs/types/models/DeviceStatus.ts is excluded by !libs/types/models/**
  • libs/types/models/DeviceSystemInfoStatus.ts is excluded by !libs/types/models/**
  • libs/types/models/DeviceSystemInfoStatuses.ts is excluded by !libs/types/models/**
  • libs/types/models/DeviceSystemInfoSummaryStatus.ts is excluded by !libs/types/models/**
  • libs/types/models/ImageDeltaHint.ts is excluded by !libs/types/models/**
  • libs/types/models/ImageSpec.ts is excluded by !libs/types/models/**
  • libs/types/models/InlineApplicationProviderSpec.ts is excluded by !libs/types/models/**
  • libs/types/models/LabelSyncMapping.ts is excluded by !libs/types/models/**
  • libs/types/models/LabelSyncMappingList.ts is excluded by !libs/types/models/**
  • libs/types/models/LabelSyncMappingSpec.ts is excluded by !libs/types/models/**
  • libs/types/models/LabelSyncMappingStatus.ts is excluded by !libs/types/models/**
  • libs/types/models/SystemInfoSourceStatus.ts is excluded by !libs/types/models/**
  • libs/types/models/SystemInfoSourceStatusType.ts is excluded by !libs/types/models/**
  • libs/types/models/SystemInfoSummaryStatusType.ts is excluded by !libs/types/models/**
📒 Files selected for processing (3)
  • libs/types/index.ts
  • libs/ui-components/src/components/Application/ApplicationDeltaStatusFields.tsx
  • libs/ui-components/src/components/Device/DeviceDetails/DeviceDeltaUpdateStatusFields.tsx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The change adds exports for status-related types and updates application and device components to read delta sizes from their respective deltaSize fields.

Changes

Status exports and delta-size fields

Layer / File(s) Summary
Export status-related types
libs/types/index.ts
The types entry point re-exports device delta outcome, device system-info status, label-sync mapping, and system-info source status types.
Read delta sizes from status fields
libs/ui-components/src/components/Application/ApplicationDeltaStatusFields.tsx, libs/ui-components/src/components/Device/DeviceDetails/DeviceDeltaUpdateStatusFields.tsx
The application component reads the size from appStatus.deltaSize. The device component reads it from deviceStatus.os.deltaSize and continues to read the fallback reason from lastDelta.fallbackReason.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested labels: risk:ask, api-types, ui-components

Merge Risk: ⚪ Minimal · up to 9b670

The application and device views now read delta sizes from their corresponding status fields. No actionable merge-blocking risk is evident in this change.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Generated-Files-Not-Hand-Edited ⚠️ Warning The PR changes 21 files under libs/types/models/**, which is a generated path covered by this check. Representative files include DeviceDeltaApplyOutcomeType.ts, DeviceApplicationStatus.ts, `Dev… Revert the hand-edited files under libs/types/models/** and regenerate the OpenAPI types with npm run gen-types. Commit the generated output from that command instead of direct edits.
✅ Passed checks (14 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed No hardcoded secret was introduced. The reviewed diff adds generated TypeScript models, enum values, type exports, and delta-size field changes. Added lines contain no API keys, passwords, tokens, cre…
No-Weak-Crypto ✅ Passed PASS. The PR changes generated OpenAPI types and delta-status UI field access. The authoritative diff adds no MD5, SHA-1, DES, 3DES, RC4, Blowfish, or ECB usage, custom cryptography, or secret/token c…
No-Injection-Vectors ✅ Passed No injection vector is introduced. The complete PR diff and all 25 changed files contain no eval/exec, dangerouslySetInnerHTML, os.system, exec.Command, or yaml.load. The UI changes render deltaSize a…
Container-Privileges ✅ Passed No container or Kubernetes manifest changed in the pull-request range. Added lines contain none of privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation. The changes are li…
No-Sensitive-Data-In-Logs ✅ Passed No logging was added or modified in the pull request. The diff contains generated type declarations and UI field-source changes only. No console, logger, telemetry, debug, or print calls appear in add…
Resource-Leaks ✅ Passed PASS: The review-scoped diff changes only TypeScript model exports and UI components. It contains no changes under proxy/ and no Go files. Therefore, this pull request does not introduce an opened res…
Unchecked-Errors ✅ Passed The authoritative pull-request diff changes only TypeScript model/index files and two TSX components. It contains no changed Go files under proxy/, so this check has no applicable changed code to as…
Ai-Attribution ✅ Passed The reviewed commit contains Made-with: Cursor, which is an explicitly acceptable AI attribution trailer. No Co-Authored-By AI attribution appears in the commit metadata. The PR description also i…
I18n-Compliance ✅ Passed PASS. The pull request changes only two .tsx files. Their changed lines update data-field access and a comment; they add no user-facing strings. All existing user-facing labels and messages in both co…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: updating types to the October 1, 2026 OpenAPI schema. It is concise and related to the schema and UI updates.
Full details: Generated-Files-Not-Hand-Edited

Explanation

The PR changes 21 files under libs/types/models/**, which is a generated path covered by this check. Representative files include DeviceDeltaApplyOutcomeType.ts, DeviceApplicationStatus.ts, DeviceOsStatus.ts, LabelSyncMapping.ts, and SystemInfoSourceStatus.ts; each contains the generated-file header generated using openapi-typescript-codegen -- do no edit. The PR does not change the generated locale file.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added api-types risk:ask Ask: medium+ risk — human review required ui-components labels Oct 1, 2026

@asafbennatan asafbennatan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@celdrake
celdrake merged commit 641e637 into flightctl:main Oct 1, 2026
11 checks passed
@celdrake
celdrake deleted the app-delta-update-size branch October 1, 2026 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-types release-1.4 risk:ask Ask: medium+ risk — human review required ui-components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants